Bug 1813005

Summary: Prevent --tuning option to be applied in Capsule servers
Product: Red Hat Satellite Reporter: sthirugn <sthirugn>
Component: InstallationAssignee: satellite6-bugs <satellite6-bugs>
Status: CLOSED ERRATA QA Contact: Devendra Singh <desingh>
Severity: high Docs Contact:
Priority: unspecified    
Version: 6.7.0CC: egolov, mmccune
Target Milestone: 6.8.0Keywords: Triaged
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: foreman-installer-2.1.0-0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-10-27 13:00:52 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description sthirugn@redhat.com 2020-03-12 17:27:49 UTC
Description of problem:
Prevent --tuning option to be applied in Capsule servers

Version-Release number of selected component (if applicable):
Satellite 6.7.0

How reproducible:
Always

Steps to Reproduce:
1. Satellite 6.7 introduces predefined tuning profiles --tuning option in the installer.
2. Currently --tuning option is shown for Capsule as well, but the way it is implemented - it is currently applicable for Satellite only and may cause user confusion and unwanted Capsule configuration if the user applies it to Capsule by mistake.

Actual results:
# satellite-installer --scenario capsule --help | grep 'tuning'
    --tuning INSTALLATION_SIZE    Tune for an installation size. Choices: default, medium, large, extra-large, extra-extra-large (default: "default")

Expected results:
# satellite-installer --scenario capsule --help | grep 'tuning'
<no output>

Additional info:

Comment 5 Bryan Kearney 2020-03-19 22:03:02 UTC
Moving this bug to POST for triage into Satellite 6 since the upstream issue https://projects.theforeman.org/issues/29339 has been resolved.

Comment 7 Devendra Singh 2020-06-05 10:31:31 UTC
Build Version: 6.8 Snap3

Verified point(On Capsule Server):
1- foreman installer version: foreman-installer-2.1.0-0.3.rc2.el7sat.noarch
2- There is no helper available in satellite-installer

#  satellite-installer --scenario capsule --help | grep 'tuning'
#

3- Check the satellite-installer with the tuning parameter on the capsule and it failed as expected.
# satellite-installer --tuning large
ERROR: Unrecognised option '--tuning'

See: 'satellite-installer --help'


@sthirugn
Tuning size(extra-extra-large.yaml  extra-large.yaml etc) are still available in /usr/share/foreman-installer/config/foreman.hiera/tuning/sizes directory, will it make any impact on the fix?

Comment 8 sthirugn@redhat.com 2020-06-05 13:11:50 UTC
(In reply to Devendra Singh from comment #7)
> Build Version: 6.8 Snap3
> 
> Verified point(On Capsule Server):
> 1- foreman installer version: foreman-installer-2.1.0-0.3.rc2.el7sat.noarch
> 2- There is no helper available in satellite-installer
> 
> #  satellite-installer --scenario capsule --help | grep 'tuning'
> #
> 
> 3- Check the satellite-installer with the tuning parameter on the capsule
> and it failed as expected.
> # satellite-installer --tuning large
> ERROR: Unrecognised option '--tuning'
> 
> See: 'satellite-installer --help'

This is how it is expected to work.
 
> 
> @sthirugn
> Tuning size(extra-extra-large.yaml  extra-large.yaml etc) are still
> available in /usr/share/foreman-installer/config/foreman.hiera/tuning/sizes
> directory, will it make any impact on the fix?

nope, the definitions themselves will still be present in the capsule server. The installer identifies this as a capsule server and blocks tuning related features. In other words - no impact.

Comment 9 Devendra Singh 2020-06-05 13:33:09 UTC
Verified on 6.8 Snap3.

Comment 12 errata-xmlrpc 2020-10-27 13:00:52 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: Satellite 6.8 release), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:4366