Bug 1813198
Summary: | Added CD ROMs in UI other than Windows Guest Disk use VirtIO instead of sata | ||||||
---|---|---|---|---|---|---|---|
Product: | OpenShift Container Platform | Reporter: | Radim Hrazdil <rhrazdil> | ||||
Component: | Console Kubevirt Plugin | Assignee: | Gilad Lekner <glekner> | ||||
Status: | CLOSED ERRATA | QA Contact: | Radim Hrazdil <rhrazdil> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | unspecified | ||||||
Version: | 4.4 | CC: | aos-bugs, glekner, gouyang, ncredi, yzamir | ||||
Target Milestone: | --- | ||||||
Target Release: | 4.5.0 | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | |||||||
: | 1817394 (view as bug list) | Environment: | |||||
Last Closed: | 2020-07-13 17:19:58 UTC | Type: | Bug | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | |||||||
Bug Blocks: | 1817394 | ||||||
Attachments: |
|
Description
Radim Hrazdil
2020-03-13 08:40:23 UTC
Given users will probably not attach any other cdroms in the wizard than the guest tools and, if they choose to add some, they can change the default in the UI to sata, I would not block the 4.4 on it. Still, I'd propose to get this to 4.4.1. @Nelly: WDYT? ack on 4.4.1 wasn't this already fixed on https://github.com/openshift/console/pull/5035 ? @Gilad the PR 5035 fixes adding the CD from Details, but in the Wizard there is still virtio by default PR - https://github.com/kubevirt/common-templates/pull/148 this bug is fixed through common-templates repo I do not believe the current version of that common-templates patch will fix the bug. Explained in the PR. @Gilad hi, can you make some order here :-) a - what is the PR (or PRs) that need to be merged for this BZ to become modified ? b - what is the current status of this PR (post or modified) ? this BZ targets 4.4 https://bugzilla.redhat.com/show_bug.cgi?id=1817394 is a clone of this PR, and targets 4.5 Both are the same bug. https://github.com/openshift/console/pull/5334 will fix the issue for 4.4 and then we will create another one for 4.5 Waiting for Review from Filip. IIUC, according to BZ1802001, VirtIO should not be considered an option for CD ROMs at all. Currently, when user opens the CD Rom dialog in VM Wizard, VirtIO is selected by default. That is incorrect, as we know beforehand that VM with VirtIO CD ROM will fail to be created. Used console release-4.5 branch commit: 5994c64ee529b650bae348ef78ebc23dca8db5c5 Created attachment 1690113 [details]
screenshot
Gilad correctly pointed out that I was missing up to date common-templates, after updating it works as expected. However, the fix is atm not present in release-4.5, so I'm moving this back to ON_QA Filed a new bug 1838397 for #13. Verified in release-4.5 branch, commit 531a1d33d7e03f487646c7569d5bce742501cb02 For Windows VMs: sata is the only interface type that is available in Wizard CD ROM dialog For Linux OSes: VirtIO is still one of the options, but isn't marked as RECOMMENDED anymore. We can handle that in BZ 1838397. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2020:2409 |