Bug 1813656

Summary: [NooBaa CLI + UI] Kubernetes Pool node limit isn't communicated/enforced
Product: [Red Hat Storage] Red Hat OpenShift Container Storage Reporter: Ben Eli <belimele>
Component: Multi-Cloud Object GatewayAssignee: Romy Ayalon <rayalon>
Status: CLOSED ERRATA QA Contact: aberner
Severity: low Docs Contact:
Priority: low    
Version: 4.3CC: ebenahar, etamir, nbecker, ocs-bugs
Target Milestone: ---   
Target Release: OCS 4.4.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 4.4.0-410 Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-06-04 12:54:37 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Ben Eli 2020-03-15 09:58:24 UTC
Description of problem (please be detailed as possible and provide log
snippests):
When creating a Kubernetes Pool via the NooBaa web UI, there is no limit on the amount of pods the user can create. 

When creating a pv-store via the CLI, the limit is 20, but this is not communicated properly:
> nb backingstore create pv-pool testing --num-volumes=21
INFO[0002] ✅ Exists: NooBaa "noobaa"                    
FATA[0002] ❌ Number of volumes seems to be too large 21 

A good example of handling this can be seen when the user tries to use a size lower than 16GBs:
FATA[0007] ❌ PV size seems to be too small (15GB), minimal size for a pv is 16GB 

It states what was the user input, and what is the minimum

Version of all relevant components (if applicable):
NB 
5.3.0-df3abc2
OCS
4.3.0-376.ci

Does this issue impact your ability to continue to work with the product
(please explain in detail what is the user impact)?
No

Is there any workaround available to the best of your knowledge?
Create no more than 20 storage nodes

Rate from 1 - 5 the complexity of the scenario you performed that caused this
bug (1 - very simple, 5 - very complex)?
1


Actual results:
In the UI - creation is possible and goes through
In the CLI - the max amount isn't documented

Expected results:
In the UI - creation is blocked
In the CLI - the max amount is stated as part of the error message

Additional info:
I think it might be a good idea to include the maximum sizes in the options docs.
i.e.:
Options:
      --num-volumes=0: Number of volumes in the store (Max 20)
      --pv-size-gb=0: PV size of each volume in the store (Min. 16)
      --storage-class='': The storage class to use for PV provisioning

Comment 4 aberner 2020-05-13 15:37:18 UTC
Verified.
1) UI shows the limit amount of nodes and doesnt allow the creation outside of the limit.
2) CLI rejects the creation of above the limit number of nodes and displays the limitation.

Comment 6 errata-xmlrpc 2020-06-04 12:54:37 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2393