Bug 1813737

I have another package under review as I await a sponsor: https://bugzilla.redhat.com/show_bug.cgi?id=1808276 and https://bugzilla.redhat.com/show_bug.cgi?id=1812411

Successful build: https://download.copr.fedorainfracloud.org/results/wef/azote/fedora-32-x86_64/01305908-azote/

>License:  GPL
The proper identifier here would be "GPLv3".
https://fedoraproject.org/wiki/Licensing:Main#Good_Licenses

>Source0:  ${url}/archive/v%{version}.tar.gz
percent-URL, not dollar-URL - the latter is a bash variable, not an rpm variable.

>Requires: python-send2trash
Unversioned python is a big no-no in Fedora; use "python3-send2trash" here.
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_dependencies

>install -p -D -m 0644 -t %{buildroot}/%{_datadir}/applications dist/%{name}.desktop
Add a BuildRequires for "desktop-file-utils" and run desktop-file-validate on the installed desktop file.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_file_install_usage

Thanks for your help, Artur.

I have incorporated your changes in build https://download.copr.fedorainfracloud.org/results/wef/azote/fedora-32-x86_64/01306271-azote/azote-1.7.10-2.fc32.wef.src.rpm

Source URL: https://download.copr.fedorainfracloud.org/results/wef/azote/fedora-32-x86_64/01306271-azote/azote-1.7.10-2.fc32.wef.x86_64.rpm
Spec URL:   https://download.copr.fedorainfracloud.org/results/wef/azote/fedora-32-x86_64/01306271-azote/azote.spec

Bundled colorthief.py is BSD licensed.
You either need to remove it and replace with dependency to 'python3-colorthief' or change license to 'GPLv3 and BSD'. Using dependency is a preferred way.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling

> Source0:  %{url}/archive/v%{version}.tar.gz
I believe the standard for github sources is %{url}/archive/v%{version}/%{name}-%{version}.tar.gz. Although it is a cosmetic change that only affects file name in lookaside cache.

> %autosetup -n %{name}-%{version}
%{name}-%{version} is already default for %autosetup. You only need to use `-n` when the toplevel directory of source archive does not match %{name}-%{version} pattern.

(In reply to Aleksei Bavshin from comment #4)
> Bundled colorthief.py is BSD licensed.
> You either need to remove it and replace with dependency to
> 'python3-colorthief' or change license to 'GPLv3 and BSD'. Using dependency is a preferred way.

Sorry, 'python3-colorthief' is actually not available in Fedora repository. I had it installed from COPR.
The guidelines section on bundling still applies here and it's preferable to have separate package.

Thanks for your help, Aleksei.

>> Source0:  %{url}/archive/v%{version}.tar.gz
> I believe the standard for github sources is %{url}/archive/v%{version}/%{name}-%{version}.tar.gz. 

This has been troubling me for a while - the upstream releases page (https://github.com/nwg-piotr/azote/releases) has this url for the source:

https://github.com/nwg-piotr/azote/archive/v1.7.10.tar.gz

I would dearly love to know how to get github to serve %{name}-%{version}.tar.gz but I've come up with nothing, even trying %forgeurl.

2/ I've taken the 'GPLv3 and BSD' option as the colorthief dependency is not available. This implies bundling so I've included this in the spec:

Provides: bundled(python3-colorthief) = 0.2.1

... or is that only for compiled libraries?

Rebuilds:

Source URL: https://download.copr.fedorainfracloud.org/results/wef/azote/fedora-32-x86_64/01309304-azote/azote-1.7.10-3.fc32.wef.src.rpm
Spec URL:   https://download.copr.fedorainfracloud.org/results/wef/azote/fedora-32-x86_64/01309304-azote/azote.spec

(In reply to Bob Hepple from comment #6)
> Thanks for your help, Aleksei.
> 
> >> Source0:  %{url}/archive/v%{version}.tar.gz
> > I believe the standard for github sources is %{url}/archive/v%{version}/%{name}-%{version}.tar.gz. 
> 
> This has been troubling me for a while - the upstream releases page
> (https://github.com/nwg-piotr/azote/releases) has this url for the source:
> 
> https://github.com/nwg-piotr/azote/archive/v1.7.10.tar.gz
> 
> I would dearly love to know how to get github to serve
> %{name}-%{version}.tar.gz but I've come up with nothing, even trying
> %forgeurl.
> 

https://github.com/nwg-piotr/azote/archive/v1.7.10/azote-1.7.10.tar.gz works, see
https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Github

So the source URL suggested by Aleksei should work.

Thanks Tim, rebuilt accordingly:

SRPM URL: https://download.copr.fedorainfracloud.org/results/wef/azote/fedora-32-x86_64/01309451-azote/azote-1.7.10-4.fc32.wef.src.rpm
SPEC URL: https://download.copr.fedorainfracloud.org/results/wef/azote/fedora-32-x86_64/01309451-azote/azote.spec

 - Remove your wef thingie in Release:

 - Add a newline between changelog entries

 - No:

%global debug_package %{nil}

the package should be noarch instead:

BuildArch: noarch

 - Add a comment explaining the license breakdown:

# GPLv3: main program
# BSD: colorthief.py
License:  GPLv3 and BSD

Latest build:

SPEC URL: https://download.copr.fedorainfracloud.org/results/wef/azote/fedora-31-x86_64/01323927-azote/azote.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/wef/azote/fedora-31-x86_64/01323927-azote/azote-1.7.10-5.fc31.src.rpm

Package approved.

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/azote

FEDORA-2020-8a0d86a630 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-8a0d86a630

FEDORA-2020-f5187a56b4 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-f5187a56b4

FEDORA-EPEL-2020-a9d5b16ad2 has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-a9d5b16ad2

FEDORA-2020-8a0d86a630 has been pushed to the Fedora 32 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-8a0d86a630 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-8a0d86a630

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-EPEL-2020-a9d5b16ad2 has been pushed to the Fedora EPEL 8 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-a9d5b16ad2

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2020-f5187a56b4 has been pushed to the Fedora 31 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-f5187a56b4 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-f5187a56b4

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2020-f5187a56b4 has been pushed to the Fedora 31 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-EPEL-2020-a9d5b16ad2 has been pushed to the Fedora EPEL 8 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2020-8a0d86a630 has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.