Bug 1814022

Summary:	Suppress safe LVM warnings on RHEL 8.2
Product:	[oVirt] vdsm	Reporter:	Nir Soffer <nsoffer>
Component:	Core	Assignee:	Amit Bawer <abawer>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Shir Fishbain <sfishbai>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	4.40.0	CC:	abawer, bugs, eshenitz, sfishbai, tnisan
Target Milestone:	ovirt-4.4.1	Flags:	abawer: needinfo- sbonazzo: ovirt-4.4? sbonazzo: planning_ack? sbonazzo: devel_ack? sbonazzo: testing_ack?
Target Release:	4.40.19
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	vdsm-4.40.19	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-07-08 08:26:30 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Storage	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Nir Soffer 2020-03-16 19:02:05 UTC

Description of problem:

On RHEL 8.2 LVM logs new warnings that are expected condition in oVirt cluster,
and should not be logged as warning in vdsm log.

Here are some examples from bug 1812802:

    WARNING: ignoring metadata seqno 1566 on /dev/mapper/x for seqno 1567 on /dev/mapper/y for VG vg-name.
    WARNING: Inconsistent metadata found for VG Bug.

But there may be other warnings that should be suppressed.

Version-Release number of selected component (if applicable):
4.40

How reproducible:
Depends on warning, some appear always, some only during stress tests.

How to fix:
- Grep vdsm log from OST and QE tests for "WARNING:" in lvm commands.
- Check with LVM developers which warnings are safe to suppress
- Add the safe warnings to
  https://github.com/oVirt/vdsm/blob/e2789fecef0858c619dceeb1fc671c154f8f69e9/lib/vdsm/storage/lvm.py#L260
- Remove warnings which are not logged in RHEL 8.2

Comment 1 Amit Bawer 2020-05-24 15:20:39 UTC

uploaded work done so far, in case this is re-assigned to someone else while i have to work on 1837199.

Comment 2 Amit Bawer 2020-05-27 11:20:41 UTC

Warnings Un-Suppressed at current cycle:

WARNING: Configuration setting "global/event_activation" unknown.

- This is expected to show only on fc30 platforms using lvm2-2.02 which did not support disabling automatic lv devices activation and as such would warn. 
  So it is not relevant for 4.4


WARNING: Combining activation change with other commands is not advised.
    
 - This used to occur when mixing lv activtaion with changing tags (for example in create and delete volume).
 - Now that BZ#1639360 is fixed we unsuppress this warning as it should not occur upon LVM commands execution.


Warning Suppressed at current cycle:

WARNING: ignoring metadata seqno 1566 on /dev/mapper/x for seqno 1567 on /dev/mapper/y for VG vg-name.
WARNING: Inconsistent metadata found for VG vg-name.


Probably most standard QE tests with block domains had those warnings,
with the patched Vdsm they should not be in vdsm.log for the WARN logs in LVM commands executions.

This BZ could be reopened later for additional warning we would like to suppress.

Comment 3 Sandro Bonazzola 2020-06-19 10:08:16 UTC

This bug is in modified state and targeted to 4.4.2. can this be re-targeted to 4.4.1?

Comment 4 Amit Bawer 2020-06-21 07:09:53 UTC

(In reply to Sandro Bonazzola from comment #3)
> This bug is in modified state and targeted to 4.4.2. can this be re-targeted
> to 4.4.1?

Since already put on "modified", I see no reason why not. Changed.

Comment 7 Shir Fishbain 2020-07-01 09:28:52 UTC

Verified with David Vaanunu from the scale team.

Ran the following greps on sacle environment and the warnings from comment2 doesn't appear

# grep -i "ignoring metadata" vdsm.log.[5-8]?
# grep -i "Inconsistent metadata" vdsm.log.[5-8]?

vdsm version : vdsm-4.40.19-1.el8ev.x86_64

Comment 8 Sandro Bonazzola 2020-07-08 08:26:30 UTC

This bugzilla is included in oVirt 4.4.1 release, published on July 8th 2020.

Since the problem described in this bug report should be resolved in oVirt 4.4.1 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.