Bug 1814226

Summary:	[Kubevirt-Foreman] Validation of Storage size behaves differently when 'G' unit is provided
Product:	Red Hat Satellite	Reporter:	Vladimír Sedmík <vsedmik>
Component:	Compute Resources - CNV	Assignee:	satellite6-bugs <satellite6-bugs>
Status:	CLOSED ERRATA	QA Contact:	Lukáš Hellebrandt <lhellebr>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	6.7.0	CC:	ehelms
Target Milestone:	6.10.0	Keywords:	Triaged
Target Release:	Unused
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-11-16 14:09:07 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Vladimír Sedmík 2020-03-17 12:24:31 UTC

Description of problem:
The storage size verification implemented for BZ [1] and [2] behaves differently when 'G' unit is provided.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1700769
[2] https://bugzilla.redhat.com/show_bug.cgi?id=1737418

Version-Release number of selected component (if applicable):
satellite-6.7.0-6.el7sat.noarch
tfm-rubygem-foreman_kubevirt-0.1.7-1.el7sat.noarch
tfm-rubygem-fog-kubevirt-1.3.3-1.el7sat.noarch

How reproducible:
always

Steps to Reproduce:
see the steps in [1] and [2]

Actual results:
for [1] different error is shown
for [2] passes successfully but shouldn't

Expected results:
for [1] and [2] similar error message as for M,T,P,E units or pass assuming the provided value is in GB

Additional info:

Comment 3 Shira Maximov 2020-06-02 11:52:50 UTC

Created redmine issue https://projects.theforeman.org/issues/29985 from this bug

Comment 4 Bryan Kearney 2020-08-03 12:05:55 UTC

Upstream bug assigned to mshira

Comment 5 Bryan Kearney 2020-08-03 12:05:57 UTC

Moving this bug to POST for triage into Satellite since the upstream issue https://projects.theforeman.org/issues/29985 has been resolved.

Comment 6 Brad Buckingham 2021-01-08 20:22:43 UTC

Hi Shira,

Has this fix been built/delivered in a version of foreman kubevirt?

It looks like current Satellite 6.9 builds have: tfm-rubygem-fog-kubevirt-1.3.3-1.el7sat.noarch.rpm , tfm-rubygem-foreman_kubevirt-0.1.8-1.el7sat.noarch.rpm


Thanks!

Comment 7 Shira Maximov 2021-01-14 10:00:11 UTC

Hi Brad, 
This PR wasn't released in any version yet, I will create a new release and package it.

Comment 9 Petr Pochop 2021-07-08 13:01:15 UTC

Verified on Sat 6.10 snap 7.0
tfm-rubygem-foreman_kubevirt-0.1.9-2.el7sat.noarch
tfm-rubygem-fog-kubevirt-1.3.3-2.el7sat.noarch

The values with "G" still pass. However, there is clearly additional parsing done later, as the pvc request passes with correct values.

Comment 13 errata-xmlrpc 2021-11-16 14:09:07 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: Satellite 6.10 Release), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:4702