Bug 1814243

Please acknowledge that you have read this message and that you can dedicate time to fix it. If you know already that you won't be able to fix it by the deadline, please let us know ASAP, so we can allocate resources to do that. Thank You.

I am not sure. :) I am adding cverna here who is taking on bodhi support...

I will be looking at fixing this in bodhi upstream.

I've done:

# bodhi/tests/server/tasks/test_composer.py is Python 3.9 incompatible
# https://github.com/fedora-infra/bodhi/issues/4007
.test-venv/bin/python3 /usr/bin/py.test-3 --cov-fail-under=%{cov_fail_under} -v bodhi/tests --ignore bodhi/tests/server/tasks/test_composer.py

It uncovered more problems:

https://copr.fedorainfracloud.org/coprs/g/python/python3.9/build/1373946/

There is bz1831336 and others:

>       c = bindings.BodhiClient()
bodhi/tests/client/test___init__.py:849: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
bodhi/client/bindings.py:206: in __init__
    super(BodhiClient, self).__init__(base_url, login_url=base_url + 'login', username=username,
/usr/lib/python3.9/site-packages/fedora/client/openidbaseclient.py:181: in __init__
    self._load_cookies()
/usr/lib/python3.9/site-packages/fedora/client/openidbaseclient.py:317: in _load_cookies
    data = json.loads(f.read(), encoding='utf-8')
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
s = '{}', cls = <class 'json.decoder.JSONDecoder'>, object_hook = None
parse_float = None, parse_int = None, parse_constant = None
object_pairs_hook = None, kw = {'encoding': 'utf-8'}
    def loads(s, *, cls=None, object_hook=None, parse_float=None,
            parse_int=None, parse_constant=None, object_pairs_hook=None, **kw):
        """Deserialize ``s`` (a ``str``, ``bytes`` or ``bytearray`` instance
        containing a JSON document) to a Python object.
    
        ``object_hook`` is an optional function that will be called with the
        result of any object literal decode (a ``dict``). The return value of
        ``object_hook`` will be used instead of the ``dict``. This feature
        can be used to implement custom decoders (e.g. JSON-RPC class hinting).
    
        ``object_pairs_hook`` is an optional function that will be called with the
        result of any object literal decoded with an ordered list of pairs.  The
        return value of ``object_pairs_hook`` will be used instead of the ``dict``.
        This feature can be used to implement custom decoders.  If ``object_hook``
        is also defined, the ``object_pairs_hook`` takes priority.
    
        ``parse_float``, if specified, will be called with the string
        of every JSON float to be decoded. By default this is equivalent to
        float(num_str). This can be used to use another datatype or parser
        for JSON floats (e.g. decimal.Decimal).
    
        ``parse_int``, if specified, will be called with the string
        of every JSON int to be decoded. By default this is equivalent to
        int(num_str). This can be used to use another datatype or parser
        for JSON integers (e.g. float).
    
        ``parse_constant``, if specified, will be called with one of the
        following strings: -Infinity, Infinity, NaN.
        This can be used to raise an exception if invalid JSON numbers
        are encountered.
    
        To use a custom ``JSONDecoder`` subclass, specify it with the ``cls``
        kwarg; otherwise ``JSONDecoder`` is used.
        """
        if isinstance(s, str):
            if s.startswith('\ufeff'):
                raise JSONDecodeError("Unexpected UTF-8 BOM (decode using utf-8-sig)",
                                      s, 0)
        else:
            if not isinstance(s, (bytes, bytearray)):
                raise TypeError(f'the JSON object must be str, bytes or bytearray, '
                                f'not {s.__class__.__name__}')
            s = s.decode(detect_encoding(s), 'surrogatepass')
    
        if (cls is None and object_hook is None and
                parse_int is None and parse_float is None and
                parse_constant is None and object_pairs_hook is None and not kw):
            return _default_decoder.decode(s)
        if cls is None:
            cls = JSONDecoder
        if object_hook is not None:
            kw['object_hook'] = object_hook
        if object_pairs_hook is not None:
            kw['object_pairs_hook'] = object_pairs_hook
        if parse_float is not None:
            kw['parse_float'] = parse_float
        if parse_int is not None:
            kw['parse_int'] = parse_int
        if parse_constant is not None:
            kw['parse_constant'] = parse_constant
>       return cls(**kw).decode(s)
E       TypeError: __init__() got an unexpected keyword argument 'encoding'
/usr/lib64/python3.9/json/__init__.py:359: TypeError


Looks like a bug in python-fedora.

BTW There is another failure with Python 3.9.0b1, when generating documentation:

error while formatting arguments for bodhi.client.bindings.BodhiClient.candidates: type object 'Iterable' has no attribute '_special'

I don't yet really understand that error, because I don't see anything like _special in bodhi's code.

(In reply to Miro Hrončok from comment #5)
> BTW There is another failure with Python 3.9.0b1, when generating
> documentation:
> 
> error while formatting arguments for
> bodhi.client.bindings.BodhiClient.candidates: type object 'Iterable' has no
> attribute '_special'
> 
> I don't yet really understand that error, because I don't see anything like
> _special in bodhi's code.

That is a Sphinx thing possibly fixed in https://github.com/sphinx-doc/sphinx/commit/46372726de435cbc6b70c99d95b7986f76563df4

(In reply to Miro Hrončok from comment #6)
> (In reply to Miro Hrončok from comment #5)
> > BTW There is another failure with Python 3.9.0b1, when generating
> > documentation:
> > 
> > error while formatting arguments for
> > bodhi.client.bindings.BodhiClient.candidates: type object 'Iterable' has no
> > attribute '_special'
> > 
> > I don't yet really understand that error, because I don't see anything like
> > _special in bodhi's code.
> 
> That is a Sphinx thing possibly fixed in
> https://github.com/sphinx-doc/sphinx/commit/
> 46372726de435cbc6b70c99d95b7986f76563df4

Fixed this one.

https://src.fedoraproject.org/rpms/bodhi/pull-request/11