Bug 1814596
| Summary: | DNF check-update hangs and waiting for stdin | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Martin Styk <mastyk> |
| Component: | dnf | Assignee: | rpm-software-management |
| Status: | CLOSED EOL | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | high | ||
| Version: | 32 | CC: | awilliam, bugzilla, dgilmore, dmach, jmracek, jrohel, kevin, mblaha, mboddu, mhatina, packaging-team-maint, pkratoch, rpm-software-management, vmukhame |
| Target Milestone: | --- | Keywords: | Triaged |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-05-25 18:01:08 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Martin Styk
2020-03-18 10:54:24 UTC
When looking at this from an admin perspective, it's probably not a good idea to automatically import GPG keys when running check-updates. In this case, you probably should add -y/--assumeyes to the kickstart. DNF could be changed to fail on importing a key during check-update to make it non-interactive again. (In reply to Daniel Mach from comment #1) > When looking at this from an admin perspective, > it's probably not a good idea to automatically > import GPG keys when running check-updates. > > In this case, you probably should add -y/--assumeyes to the kickstart. Yes > > DNF could be changed to fail on importing a key during check-update > to make it non-interactive again. I agree. I'm completely fine with failure. Otherwise, docs should be updated accordingly. So whether this is a sensible thing to do in a kickstart is maybe up for debate, but seems there is a real new problem here. You're not supposed to have to sign off on the import of a GPG key on first use like this, IIRC. This is probably caused by the enabling of the Cisco repo by default, which was https://bugzilla.redhat.com/show_bug.cgi?id=1807679 . CCing folks from that bug here: were we expecting this kind of trust prompt? Can we make it not happen? Well, I think this is really https://bugzilla.redhat.com/show_bug.cgi?id=1768206 ? ie, it always prompts for the key import even if it's been imoprted already via rpm --import due to the repodata gpg check being enabled... oh, so it's because this repo has repo_gpgcheck=1 ? repo_gpgcheck=1 needs the key to get imported into dnf's databases and not rpm's in order to verify the metadata has not been tampered with, and as the cisco repo bypasses mirrormanager we have no other protection for man in the middle attacks on the repo Kevin, this is more than bug 1768206. In this case, you have GPGs because it is part of Fedora, however, command itself (check-update) may end up hanging on read(0. Which is against the documentation - "Non-interactively checks if updates of the specified packages are available." So the problem is still there, it is more like how you will achieve it. I am not a dnf developer, so I have no idea the way they want to solve this. ;) Perhaps dnf could pull gpg keys from rpm if they are already imported there? Or as you say, fail if they have to ask anything in a check-update. This message is a reminder that Fedora 32 is nearing its end of life. Fedora will stop maintaining and issuing updates for Fedora 32 on 2021-05-25. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '32'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 32 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. Fedora 32 changed to end-of-life (EOL) status on 2021-05-25. Fedora 32 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed. |