Bug 1814876

Summary: [Bug] Do not wait for VM IP address if no Ansible playbook will run
Product: Red Hat CloudForms Management Engine Reporter: Fabien Dupont <fdupont>
Component: V2VAssignee: Fabien Dupont <fdupont>
Status: CLOSED ERRATA QA Contact: Nandini Chandra <nachandr>
Severity: high Docs Contact: Red Hat CloudForms Documentation <cloudforms-docs>
Priority: urgent    
Version: 5.11.0CC: bthurber, simaishi, sshveta
Target Milestone: GAKeywords: ZStream
Target Release: 5.11.5Flags: pm-rhel: cfme-5.11.z+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.11.5.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-05-05 13:43:34 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: V2V Target Upstream Version:
Embargoed:

Description Fabien Dupont 2020-03-18 21:40:36 UTC
Description of problem:
In the migration workflow, it's possible to run a pre or post-migration playbook. In the current implementation, we wait for the VM to report its IP address in CloudForms inventory before moving on. But if the VM is on but doesn't have VMware tools, it won't be reported and the migration will fail even if no playbook is expected to run.

Comment 2 Fabien Dupont 2020-03-18 21:55:15 UTC
https://github.com/ManageIQ/manageiq/pull/19979

Comment 3 CFME Bot 2020-03-20 19:05:21 UTC
New commit detected on ManageIQ/manageiq/ivanchuk:

https://github.com/ManageIQ/manageiq/commit/d100b531b626cf6906c69b033d837fd3b48f9d7f
commit d100b531b626cf6906c69b033d837fd3b48f9d7f
Author:     Adam Grare <agrare>
AuthorDate: Thu Mar 19 13:55:24 2020 +0000
Commit:     Adam Grare <agrare>
CommitDate: Thu Mar 19 13:55:24 2020 +0000

    Merge pull request #19979 from fdupont-redhat/v2v_bz_1814876

    [V2V] Do not wait for IP address if no playbook is expected

    (cherry picked from commit 73eeb8fc65508c010a315201e35920f084d97a29)

    https://bugzilla.redhat.com/show_bug.cgi?id=1814876

 app/models/infra_conversion_job.rb | 7 +-
 spec/models/infra_conversion_job_spec.rb | 8 +
 2 files changed, 13 insertions(+), 2 deletions(-)

Comment 4 CFME Bot 2020-03-20 20:15:31 UTC
New commits detected on ManageIQ/manageiq/jansa:

https://github.com/ManageIQ/manageiq/commit/8aa2103dbfe51165d5e1b1415084f27b7e3738f4
commit 8aa2103dbfe51165d5e1b1415084f27b7e3738f4
Author:     Adam Grare <agrare>
AuthorDate: Thu Mar 19 13:55:24 2020 +0000
Commit:     Adam Grare <agrare>
CommitDate: Thu Mar 19 13:55:24 2020 +0000

    Merge pull request #19979 from fdupont-redhat/v2v_bz_1814876

    [V2V] Do not wait for IP address if no playbook is expected

    (cherry picked from commit 73eeb8fc65508c010a315201e35920f084d97a29)

    https://bugzilla.redhat.com/show_bug.cgi?id=1814876

 app/models/infra_conversion_job.rb | 7 +-
 spec/models/infra_conversion_job_spec.rb | 8 +
 2 files changed, 13 insertions(+), 2 deletions(-)

Comment 5 Nandini Chandra 2020-04-22 04:17:41 UTC
Verified that preflight check fails for VMs without an IP address only if pre and post migration playbooks are to be run on the VM. If no playbooks are to be run on the VM without an IP address, preflight check will succeed and so will migration.

Verified in 5.11.5.1

Comment 8 errata-xmlrpc 2020-05-05 13:43:34 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2020