Bug 1815104

Summary: Locked provisioning template should not be allowed to add audit comment
Product: Red Hat Satellite Reporter: Roman Plevka <rplevka>
Component: Provisioning TemplatesAssignee: Ondřej Pražák <oprazak>
Status: CLOSED ERRATA QA Contact: Roman Plevka <rplevka>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 6.7.0CC: mhulan, oprazak, pcreech
Target Milestone: 6.8.0Keywords: Triaged
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: foreman-2.1.2.1-1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-10-27 13:00:52 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Roman Plevka 2020-03-19 13:45:44 UTC 
The bug is completely identical to:
https://bugzilla.redhat.com/show_bug.cgi?id=1805678

but for API (and possibly CLI).


Steps to Reproduce:
1. use API or Hammer to update a locked template and add a comment to it

Actual results:
notice the update is updated
audit record regarding created audit comment is created


Expected results:
Error message should be retrieved saying that user is unable to update locked templates.
Comment 4 Ondřej Pražák 2020-07-03 12:09:03 UTC 
Created redmine issue https://projects.theforeman.org/issues/30317 from this bug
Comment 5 Bryan Kearney 2020-07-04 20:06:51 UTC 
Upstream bug assigned to oprazak
Comment 6 Bryan Kearney 2020-07-04 20:06:53 UTC 
Upstream bug assigned to oprazak
Comment 7 Bryan Kearney 2020-07-05 16:06:22 UTC 
Moving this bug to POST for triage into Satellite since the upstream issue https://projects.theforeman.org/issues/30317 has been resolved.
Comment 9 Roman Plevka 2020-09-09 08:22:10 UTC 
VERIFIED
on sat6.8.0-14

# hammer template update --id 100 --audit-comment foobar
Could not update the provisioning template:
  Cannot add audit comment to a locked template.

- no record created in audits
Comment 12 errata-xmlrpc 2020-10-27 13:00:52 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: Satellite 6.8 release), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:4366