Bug 1815577

Summary: Review Request: osbuild-composer - An HTTP service for building bootable OS images
Product: [Fedora] Fedora Reporter: Ondřej Budai <obudai>
Component: Package ReviewAssignee: Neal Gompa <ngompa13>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: daherrma, ngompa13, package-review
Target Milestone: ---Flags: ngompa13: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-03-23 13:51:21 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Ondřej Budai 2020-03-20 15:57:03 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/obudai/osbuild-composer/fedora-32-x86_64/01313538-osbuild-composer/osbuild-composer-0d496d0d495ae7ef284f71a9f789b0059c69fc84.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/obudai/osbuild-composer/fedora-32-x86_64/01313538-osbuild-composer/osbuild-composer-8-1.20200320git0d496d0.fc32.src.rpm
Description: An HTTP service for building bootable OS images. It provides the same API as lorax-composer but in the background it uses osbuild to create the images.
Fedora Account System Username: obudai

This is request for a *package rename*. There's already golang-github-osbuild-composer package in Fedora, but we (the upstream team, I'm a member of it) think that the name is confusing to the end-users. Quoting the go packaging guidelines:

> Source packages that provide a well-known application such as etcd MUST be named after the application. End users do not care about the language their applications are written in. But do not name packages after an obscure utility binary that happens to be built by the package.

We think that osbuild-composer is well-known application. Additionally, we don't ship any go library files, therefore it doesn't make sense to have go in the package name.

We maintain the spec file upstream, therefore it has also some parts for RHEL and the tests subpackage which we won't ship to Fedora (it provides zero value to the end-users). I would like to apologize, if it's a bit hard to read.

Comment 1 Neal Gompa 2020-03-21 01:14:48 UTC
Looks good to me. Looks substantially the same as the old package, and the Obsoletes+Provides are present.

Comment 2 Igor Raits 2020-03-23 08:27:31 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/osbuild-composer

Comment 3 Ondřej Budai 2020-03-23 10:18:20 UTC
Thanks, Neal and Igor! That was fast!