Bug 1815725
| Summary: | Re-Review Request: mkdocs-cinder - A clean responsive theme for the MkDocs | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Robin Lee <robinlee.sysu> |
| Component: | Package Review | Assignee: | José Matos <jamatos> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jamatos, package-review |
| Target Milestone: | --- | Flags: | jamatos:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-04-25 02:22:18 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1811410 | ||
| Bug Blocks: | |||
|
Description
Robin Lee
2020-03-21 06:57:18 UTC
After mkdocs review is done I will review this package. Fedora review complains about three things.
Two of them are true but moot:
* the name already exists because this is a re-review;
* the package does not install properly because it requires mkdocs that has just been approved.
The third is relevant:
* Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
Replace the line
%{python3_sitelib}/*
with
%{python3_sitelib}/cinder
%{python3_sitelib}/mkdocs_cinder-%{version}-py?.?.egg-info
I did not test it but it should be something along this.
Without looking I suspect that probably the other mkdocs theme probably suffer from the same problem.
Spec URL: https://download.copr.fedorainfracloud.org/results/cheeselee/review/fedora-rawhide-x86_64/01330820-mkdocs-cinder/mkdocs-cinder.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/cheeselee/review/fedora-rawhide-x86_64/01330820-mkdocs-cinder/mkdocs-cinder-1.0.3-1.fc33.src.rpm Changes: - Update to 1.0.3 - No globbing %%{python3_sitelib} The package is simple, this is a re-review and the license is correct and acceptable. The issue in %files has been fixed so the package is approved. FEDORA-2020-d4e501fac9 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-d4e501fac9 FEDORA-2020-cd3e0f6413 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-cd3e0f6413 FEDORA-2020-d4e501fac9 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-d4e501fac9 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-d4e501fac9 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2020-cd3e0f6413 has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-cd3e0f6413 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-cd3e0f6413 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2020-d4e501fac9 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2020-cd3e0f6413 has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. |