Bug 1815862

Summary:	Review Request: pfetch - a pretty system information tool written in POSIX sh
Product:	[Fedora] Fedora	Reporter:	Seth Flynn <sethaflynn>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	fedora, package-review, sethaflynn
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-03-25 11:49:22 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Seth Flynn 2020-03-22 06:56:32 UTC

Spec URL: https://raw.githubusercontent.com/sethfl/linux-packages/master/fedora/pfetch/SPECS/pfetch.spec

SRPM URL: https://github.com/sethfl/linux-packages/raw/master/fedora/pfetch/SRPMS/pfetch-0.6.0-1.src.rpm

Description: pfetch is a minimalist system information tool built with POSIX features (whenever available), making it a lightweight alternative to similar programs such as screenfetch and neofetch. Furthermore, I would also like to mention this is my first package and I am seeking a sponsor.

Fedora Account System Username: sethfl

Successful Koji/Copr Build: https://copr.fedorainfracloud.org/coprs/sethfl/pfetch/builds/

Comment 1 Artur Frenszek-Iwicki 2020-03-22 14:22:50 UTC

>Summary:    A pretty system information tool written in POSIX sh. 
No dot/period at the end, please
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections

>%prep
>%autosetup 
>wget https://raw.githubusercontent.com/dylanaraps/pfetch/master/Makefile
koji builds run without outernet access, so fetching the file via wget will fail. You need to add the file as a Source:.
For copr, you should go to your project's settings -> other options -> and disable the "Enable internet access during builds" checkbox.

>%files
>/usr/bin/pfetch
Use macros for paths.
https://docs.fedoraproject.org/en-US/packaging-guidelines/RPMMacros/#_macros_for_paths_set_and_used_by_build_systems

Comment 2 Seth Flynn 2020-03-22 21:16:34 UTC

(In reply to Artur Iwicki from comment #1)
> >Summary:    A pretty system information tool written in POSIX sh. 
> No dot/period at the end, please
> https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections
> 
> >%prep
> >%autosetup 
> >wget https://raw.githubusercontent.com/dylanaraps/pfetch/master/Makefile
> koji builds run without outernet access, so fetching the file via wget will
> fail. You need to add the file as a Source:.
> For copr, you should go to your project's settings -> other options -> and
> disable the "Enable internet access during builds" checkbox.
> 
> >%files
> >/usr/bin/pfetch
> Use macros for paths.
> https://docs.fedoraproject.org/en-US/packaging-guidelines/RPMMacros/
> #_macros_for_paths_set_and_used_by_build_systems

followed your reply, latest build without outernet access can be found here:https://copr.fedorainfracloud.org/coprs/sethfl/pfetch/build/1315052/

then the new .spec can be found here: https://raw.githubusercontent.com/sethfl/linux-packages/master/fedora/pfetch/SPECS/pfetch.spec

and finally the srpm: https://github.com/sethfl/linux-packages/raw/master/fedora/pfetch/SRPMS/pfetch-0.6.0-1.src.rpm