Bug 1816057

Summary:	Falling back to DNS,TCP doesn't help for liveliness check of the host
Product:	[oVirt] cockpit-ovirt	Reporter:	SATHEESARAN <sasundar>
Component:	gluster-ansible	Assignee:	Parth Dhanjal <dparth>
Status:	CLOSED CURRENTRELEASE	QA Contact:	SATHEESARAN <sasundar>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	0.14.2	CC:	bugs, dparth, godas, rhs-bugs
Target Milestone:	ovirt-4.4.1	Flags:	sasundar: ovirt-4.4? sasundar: planning_ack? godas: devel_ack+ sasundar: testing_ack+
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	cockpit-ovirt-0.14.8	Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:	1816051	Environment:
Last Closed:	2020-07-08 08:27:21 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Gluster	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1816051

Description SATHEESARAN 2020-03-23 09:15:46 UTC

Description of problem:
-------------------------
Current implementation of the hosts tab is done such a way it falls through the validation below:
1. Check for hosts in known_hosts
2. Ping test
3. DNS test
4. TCP test

When 'ping' or 'ping6' test fails, then the check falls back to DNS and TCP test, which is not right and will not help in liveliness check for the hosts in place.


Version-Release number of selected component (if applicable):
--------------------------------------------------------------
cockpit-ovirt-dashboard-0.14.2-1

How reproducible:
------------------
Always

Steps to Reproduce:
-------------------
1. Start with Hyperconverged deployment from UI
2. Provide the FQDN of the host which is not reachable

Actual results:
---------------
When the host is not reachable, proceeding to next tab of deployment is allowed

Expected results:
------------------
When the host is not reachable, proceeding to next tab of deployment should be abandoned

Comment 1 SATHEESARAN 2020-04-21 07:33:52 UTC

Tested it with cockpit-ovirt-dashboard-0.14.5

Problem is that before the validation is complete, there is a window, in which the user could proceed to the next tab.
We need to implement the mechanism for the validation to complete early or make user wait before the validation is complete.

Though part of the bug is addressed with removing the fall back to DNS or ping, but the really expectation of validation 
of host liveliness is not satisfied.

Comment 2 SATHEESARAN 2020-06-03 10:28:17 UTC

Tested with cockpit-ovirt-dashboard-0.14.6, observed one specific problem

When for the second host, (i.e) second row, Storage FQDN is not reachable,
then the public FQDN is reachable, user could still proceed to the next tab.

So on any occasion, if the hostname is not reachable then the logic should not
allow to proceed to the next tab

Comment 3 Sandro Bonazzola 2020-06-04 12:05:58 UTC

Moving to 4.4.1 since 4.4.0 has been already released

Comment 4 SATHEESARAN 2020-06-16 02:43:47 UTC

I see that this issue is fixed with cockpit-ovirt-dashboard-0.14.8

@Gobinda, can you check why this bug is not yet ON_QA ?

Comment 5 Gobinda Das 2020-06-16 04:49:46 UTC

Moved to ON_QA

Comment 6 SATHEESARAN 2020-06-16 04:53:45 UTC

Tested with cockpit-ovirt-dashboard-0.14.8

1. when feeding the hostnames and clicking on 'Next' button triggers the host reachability check
When the host is not reachable, it throws appropriate errors.

2. when the host name is not added to SSH known_hosts file, then also it throws proper error messages

3. When the public network name is skipped, without selecting, use same hostname for Public and storage FQDN,
then also error pops up

Comment 7 Sandro Bonazzola 2020-07-08 08:27:21 UTC

This bugzilla is included in oVirt 4.4.1 release, published on July 8th 2020.

Since the problem described in this bug report should be resolved in oVirt 4.4.1 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.