Bug 1816540
| Summary: | [4.3] Forwarded header includes empty quoted proto-version parameter | ||
|---|---|---|---|
| Product: | OpenShift Container Platform | Reporter: | Felipe M <fmarting> |
| Component: | Networking | Assignee: | Miciah Dashiel Butler Masters <mmasters> |
| Networking sub component: | router | QA Contact: | Arvind iyengar <aiyengar> |
| Status: | CLOSED ERRATA | Docs Contact: | |
| Severity: | high | ||
| Priority: | unspecified | CC: | aiyengar, amcdermo, aos-bugs, hongli, mmasters, shudili |
| Version: | 4.3.0 | ||
| Target Milestone: | --- | ||
| Target Release: | 4.3.z | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: |
Cause: When the ingress controller forwarded an HTTP request to an application, the ingress controller would add a Forwarded HTTP header with a non-standard "proto-version" parameter.
Consequence: The Forwarded header was not standards-compliant, which could cause problems when applications tried to parse the header value.
Fix: The ingress controller was modified not to specify any "proto-version" parameter in the Forwarded header.
Result: The Forwarded header should now be standards-compliant.
|
Story Points: | --- |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-07-14 16:11:52 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1816544 | ||
| Bug Blocks: | |||
|
Description
Felipe M
2020-03-24 09:08:27 UTC
The 4.3 backport is currently blocked on the 4.4 backport (bug 1816544), which needs to be QA'd before the 4.3 backport can merge. The 4.3 backport is still blocked on the 4.4 backport, which is waiting for cherry-pick approval. We'll continue to track these ports in the upcoming sprint. The PR was merged and made into "4.3.0-0.nightly-2020-07-03-062023" version. It is noted that "proto-version" is no more present in the haproxy config templates as intended: ---- $ oc get clusterversion NAME VERSION AVAILABLE PROGRESSING SINCE STATUS version 4.3.0-0.nightly-2020-07-03-062023 True False 10m Cluster version is 4.3.0-0.nightly-2020-07-03-062023 $ oc -n openshift-ingress exec pod/router-default-69dc599c6c-f4d7d -- cat haproxy-config.template | grep proto http-request add-header Forwarded for=\"[%[src]]\";host=%[req.hdr(host)];proto=%[req.hdr(X-Forwarded-Proto)] http-request add-header Forwarded for=%[src];host=%[req.hdr(host)];proto=%[req.hdr(X-Forwarded-Proto)] ---- Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2020:2872 |