Bug 181673
Summary: | cpuspeed init script might check wrongly the /proc/acpi/processor/CPU0 file | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Piergiorgio Sartor <piergiorgio.sartor> |
Component: | cpuspeed | Assignee: | Liang Zhang <lizhang> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | 4 | CC: | mshao |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | FC5 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-09-22 02:20:21 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Piergiorgio Sartor
2006-02-15 20:02:13 UTC
Bah, some ACPI BIOSes start counting CPUs at 0, and some at 1. I'll fix this up by changing /etc/init.d/cpuspeed like so.. - thr=`head -n1 /proc/acpi/processor/CPU0/throttling` + thr=`head -n1 -q /proc/acpi/processor/CPU*/throttling | uniq` That should take care of all cases. Well, don't forget to change the "if" too... :-) Maybe off topic: is there any plan to add an "automatic" module selection? I mean, right now the user has to explicitly add (and know) the proper "driver" in /etc/cpuspeed.conf, it would be really good to have it done automatically in /etc/init.d/cpuspeed, or, like for lm_sensors, having a configuration tool, which detects the proper driver and, somehow, configures the demon. whoops, I missed the if, thanks for reminding me :) long-term, I'd like this to 'just work', it's just finding the time to get the necessary work done. The init scripts should be able to figure out whats needed just by parsing /proc/cpuinfo, but it's just not something I've got around to yet. Maybe during FC6 development I'll find some time to look into it (and then backport to older releases). Closing bugs in MODIFIED state from prior Fedora releases. If this bug persists in a current Fedora release (such as Fedora Core 5 or later), please reopen and set the version appropriately. |