Bug 1817726

Summary: libblkid BLOCK_SIZE
Product: Red Hat Enterprise Linux 8 Reporter: David Teigland <teigland>
Component: util-linuxAssignee: Karel Zak <kzak>
Status: CLOSED ERRATA QA Contact: Radka Brychtova <rskvaril>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 8.3CC: pasik
Target Milestone: rc   
Target Release: 8.3   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: util-linux-2.32.1-23.el8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-11-04 02:06:13 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description David Teigland 2020-03-26 19:53:48 UTC
Description of problem:

lvm has a couple of features planned for 8.3 (writecache and integrity) that need this upstream commit to check the fs block size:

commit cd129b7d2fecd5f2013512936de2db1bf244aa75
Author: Mikulas Patocka <mpatocka>
Date:   Mon Sep 2 12:28:39 2019 +0200

    blkid: retport block size of a filesystem
    
    This patch extends libblkid, so that it reports filesystem block size.
    
    When blkid returns a specific number in the BLOCK_SIZE attribute, it
    guarantees that all the bios submitted by the filesystem are aligned on
    this boundary.
    
    We need this because when we want to enable dm-integrity or dm-writecache
    on an existing filesystem, we need to know filesystem block size, so that
    dm-integrity or dm-writecache is initialized with matching block size.
    
    We could always use block size 512 for dm-integrity and dm-writecache, but
    that would cause metadata overhead and performance degradation. On the
    other hand, if we used block size 4096, it would fail if the filesystem
    has smaller blocksize.
    
    [kzak: - move vfat BLOCK_SIZE to probing function
                      - remove unwanted debug fprintf from ZFS prober]
    
    Signed-off-by: Mikulas Patocka <mpatocka>
    Signed-off-by: Karel Zak <kzak>


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 2 David Teigland 2020-06-10 22:45:34 UTC
I'd like to find a way to test this with lvm, is there a build with this patch I can install on rhel8?
Thanks

Comment 3 Karel Zak 2020-06-11 07:12:39 UTC
(In reply to David Teigland from comment #2)
> I'd like to find a way to test this with lvm, is there a build with this
> patch I can install on rhel8?

Not yet, I plan 8.3 build for the next week.

Comment 4 David Teigland 2020-06-11 21:25:19 UTC
The new BLOCK_SIZE field is working well for lvm, thanks.

Comment 10 errata-xmlrpc 2020-11-04 02:06:13 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (util-linux bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4575