Bug 1818109

Summary: [ESXi][RHEL7.9]open-vm-tools coverity scan issue
Product: Red Hat Enterprise Linux 7 Reporter: Cathy Avery <cavery>
Component: open-vm-toolsAssignee: Cathy Avery <cavery>
Status: CLOSED ERRATA QA Contact: ldu <ldu>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 7.9CC: cavery, jen, jjarvis, jsavanyo, ldu, leiwang, ravindrakumar
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: open-vm-tools-11.0.5-3.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-09-29 19:47:47 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Cathy Avery 2020-03-27 17:47:44 UTC 
Add vmware patch to fix minor memory leak detected by coverity.

Coverity defect to be fixed

Error: RESOURCE_LEAK (CWE-772):
open-vm-tools-11.0.5-15389592/namespacetool/namespacetool.c:209: alloc_fn: Storage is returned from allocation function "g_io_channel_unix_new".
open-vm-tools-11.0.5-15389592/namespacetool/namespacetool.c:209: var_assign: Assigning: "iochannel" = storage returned from "g_io_channel_unix_new(0)".
open-vm-tools-11.0.5-15389592/namespacetool/namespacetool.c:214: noescape: Resource "iochannel" is not freed or pointed-to in "g_io_channel_read_to_end".
open-vm-tools-11.0.5-15389592/namespacetool/namespacetool.c:236: leaked_storage: Variable "iochannel" going out of scope leaks the storage it points to.
#  234|      }
#  235|      g_free(gErr);
#  236|->    return retVal;
#  237|   }
#  238|   


https://github.com/vmware/open-vm-tools/tree/devel in file namespacetool/namespacetool.c.

Git commit 8dbd6e991315bb1b0a18c369c4d2bb165ef1f184 has the fix itself.

Git commit 95bb9273cccfd38e0f3299828a0a6cf5a8c30efb has the copyright update.  Please pick this up as well.
Comment 10 ldu 2020-05-15 03:06:09 UTC 
The covscan issue had been fixed, and the test result could found in https://errata.devel.redhat.com/advisory/52745/test_run/covscan

so change status to verified.
Comment 12 errata-xmlrpc 2020-09-29 19:47:47 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (open-vm-tools bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2020:3895