Bug 1818598

Summary: python-cclib fails to build with Python 3.9: No module named 'xml.etree.cElementTree'
Product: [Fedora] Fedora Reporter: Miro Hrončok <mhroncok>
Component: python-cclibAssignee: Antonio T. (sagitter) <anto.trande>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: anto.trande, cstratak, mhroncok, mplch
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-03-29 19:44:47 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1785415    

Description Miro Hrončok 2020-03-29 14:42:49 UTC
python-cclib fails to build with Python 3.9.0a5.

+ /usr/bin/python3 -m test.test_data
Traceback (most recent call last):
  File "/usr/lib64/python3.9/runpy.py", line 194, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/lib64/python3.9/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/builddir/build/BUILD/cclib-1.6.2/test/test_data.py", line 18, in <module>
    import cclib
  File "/builddir/build/BUILD/cclib-1.6.2/cclib/__init__.py", line 28, in <module>
    from cclib import parser
  File "/builddir/build/BUILD/cclib-1.6.2/cclib/parser/__init__.py", line 37, in <module>
    from cclib.io.ccio import ccopen
  File "/builddir/build/BUILD/cclib-1.6.2/cclib/io/__init__.py", line 12, in <module>
    from cclib.io.cmlwriter import CML
  File "/builddir/build/BUILD/cclib-1.6.2/cclib/io/cmlwriter.py", line 10, in <module>
    import xml.etree.cElementTree as ET
ModuleNotFoundError: No module named 'xml.etree.cElementTree'


See https://docs.python.org/3.9/whatsnew/3.9.html#removed

"The xml.etree.cElementTree module has been removed, use the xml.etree.ElementTree module instead. Since Python 3.3 the xml.etree.cElementTree module has been deprecated, the xml.etree.ElementTree module uses a fast implementation whenever available."


For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.9/fedora-rawhide-x86_64/01322486-python-cclib/

For all our attempts to build python-cclib with Python 3.9, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/package/python-cclib/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.9:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/

Let us know here if you have any questions.

Python 3.9 will be included in Fedora 33. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.9.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Antonio T. (sagitter) 2020-03-29 19:44:47 UTC
Fixed on Rawhide.

Comment 2 Miro Hrončok 2020-03-30 08:24:18 UTC
Thanks for the fix.


%if 0%{?python3_version_nodots} == 39            
%autopatch -p1            
%endif

As a side note: This will fail with Python 3.10. Hopefully by that time, this will be already merged upstream, but this patch can be safely applied unconditionally. Since Python 3.3 the xml.etree.cElementTree module has been deprecated, the xml.etree.ElementTree module uses a fast implementation whenever available.

Comment 3 Antonio T. (sagitter) 2020-03-30 18:08:17 UTC
Patch extended to Python-3.10