Bug 1819479

Summary:	VPA controller is writing events about updating its deployments even when there is no change to the deployment
Product:	OpenShift Container Platform	Reporter:	Jessica Forrester <jforrest>
Component:	Node	Assignee:	Joel Smith <joelsmith>
Status:	CLOSED ERRATA	QA Contact:	Weinan Liu <weinliu>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	4.5	CC:	aos-bugs, jokerman
Target Milestone:	---
Target Release:	4.5.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-07-13 17:24:27 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jessica Forrester 2020-03-31 23:51:59 UTC

The VPA controller is writing out events every 8 or so minutes about updating the deployment for vpa-recommender-default and the vpa-updater-default (slightly less often). However no actual change is being made to these deployments that I can see, not even the resourceVersion. Events from my cluster are below, you can see the events were fired 400+ times in a single day. We should be only claiming we updated the deployments if an actual change was written out.




oc describe events -n openshift-vertical-pod-autoscaler
Name:             default.16013324d831da3e
Namespace:        openshift-vertical-pod-autoscaler
Labels:           <none>
Annotations:      <none>
API Version:      v1
Count:            470
Event Time:       <nil>
First Timestamp:  2020-03-30T21:46:17Z
Involved Object:
  API Version:       autoscaling.openshift.io/v1
  Kind:              VerticalPodAutoscalerController
  Name:              default
  Namespace:         openshift-vertical-pod-autoscaler
  Resource Version:  1920045
  UID:               8fe3b614-d76f-4461-84f6-2c091d346bf2
Kind:                Event
Last Timestamp:      2020-03-31T23:32:56Z
Message:             Updated VerticalPodAutoscalerController deployment: openshift-vertical-pod-autoscaler/vpa-recommender-default
Metadata:
  Creation Timestamp:  2020-03-30T21:46:17Z
  Resource Version:    2464626
  Self Link:           /api/v1/namespaces/openshift-vertical-pod-autoscaler/events/default.16013324d831da3e
  UID:                 f4449a45-a368-465c-99f3-99aceb702f5a
Reason:                SuccessfulUpdate
Reporting Component:   
Reporting Instance:    
Source:
  Component:  vertical-pod-autoscaler-controller
Type:         Normal
Events:       <none>


Name:             default.16013324d9f171e1
Namespace:        openshift-vertical-pod-autoscaler
Labels:           <none>
Annotations:      <none>
API Version:      v1
Count:            457
Event Time:       <nil>
First Timestamp:  2020-03-30T21:46:17Z
Involved Object:
  API Version:       autoscaling.openshift.io/v1
  Kind:              VerticalPodAutoscalerController
  Name:              default
  Namespace:         openshift-vertical-pod-autoscaler
  Resource Version:  1920045
  UID:               8fe3b614-d76f-4461-84f6-2c091d346bf2
Kind:                Event
Last Timestamp:      2020-03-31T23:06:18Z
Message:             Updated VerticalPodAutoscalerController deployment: openshift-vertical-pod-autoscaler/vpa-updater-default
Metadata:
  Creation Timestamp:  2020-03-30T21:46:17Z
  Resource Version:    2456526
  Self Link:           /api/v1/namespaces/openshift-vertical-pod-autoscaler/events/default.16013324d9f171e1
  UID:                 7a37c56b-85a8-4c09-adc6-947b32540fad
Reason:                SuccessfulUpdate
Reporting Component:   
Reporting Instance:    
Source:
  Component:  vertical-pod-autoscaler-controller
Type:         Normal
Events:       <none>

Comment 5 errata-xmlrpc 2020-07-13 17:24:27 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2409