Bug 1819587

Summary: Rollback does not delete SR-IOV VFs
Product: Red Hat Enterprise Linux 8 Reporter: Gris Ge <fge>
Component: NetworkManagerAssignee: Beniamino Galvani <bgalvani>
Status: CLOSED ERRATA QA Contact: Desktop QE <desktop-qa-list>
Severity: medium Docs Contact:
Priority: medium    
Version: 8.2CC: acardace, atragler, bgalvani, lrintel, mshi, rkhan, sukulkar, thaller, till, vbenes
Target Milestone: rc   
Target Release: 8.3   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: NetworkManager-1.26.0-1.el8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-11-04 01:49:27 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
System logs with NM trace enabled
none
Reproducer using netdevsim none

Description Gris Ge 2020-04-01 06:46:59 UTC
Created attachment 1675304 [details]
System logs with NM trace enabled

Description of problem:

When activating a ethernet with SRIOV configure, the rollback triggered by  failure of `min-tx-rate=1` will not remove created VFs.


Version-Release number of selected component (if applicable):
NetworkManager-1.22.8-4.el8.x86_64

How reproducible:
100%

Steps to Reproduce:

1. Find a server with igb SRIOV ready NIC. Assuming that is ens2f0.
2. Execute:

sudo nmcli c del ens2f0
sudo nmcli c add type ethernet ifname ens2f0 \
    sriov.total-vfs 1\
    sriov.vfs "0 min-tx-rate=1" \
    connection.autoconnect false \
    connection.id ens2f0 \
    ipv4.method disabled \
    ipv6.method disabled

sudo nmcli c up ens2f0
ip link |grep ens2f0

Actual results:

Got left over VF `ens2f0v1`

Expected results:

The rollback should remove VFs.

Additional info:

Got `Operation not supported` in the nm.log

Comment 2 Beniamino Galvani 2020-04-01 15:46:02 UTC
The problem is that when a connection fails we don't reset the number of VFs to zero.

Upstream merge request:

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/457

Comment 3 Beniamino Galvani 2020-07-10 09:04:38 UTC
Created attachment 1700562 [details]
Reproducer using netdevsim

Comment 7 Vladimir Benes 2020-08-18 12:23:37 UTC
test based on netdevsim device added to CI:
https://gitlab.freedesktop.org/NetworkManager/NetworkManager-ci/-/merge_requests/619

Comment 10 errata-xmlrpc 2020-11-04 01:49:27 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (NetworkManager bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4499