Bug 1819700

Summary:	CLI command to trigger the upgrade contains u/s var instead of d/s
Product:	Container Native Virtualization (CNV)	Reporter:	Irina Gulina <igulina>
Component:	Documentation	Assignee:	Andrew Burden <aburden>
Status:	CLOSED ERRATA	QA Contact:	Nelly Credi <ncredi>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	2.2.0	CC:	aburden, cnv-qe-bugs, danken, stirabos
Target Milestone:	---
Target Release:	2.3.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	2.3.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-05-04 19:10:58 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Irina Gulina 2020-04-01 10:45:59 UTC

Document URL: 
Line [1] contains HCO_CHANNEL var which is u/s. It should be CNV_CNANNEL, d/s. 

Additional information:
[1] https://github.com/openshift/openshift-docs/blame/master/cnv/cnv_release_notes/cnv-release-notes.adoc#L208

Comment 1 Andrew Burden 2020-04-01 18:05:09 UTC

Thanks Irina

PR:
https://github.com/openshift/openshift-docs/pull/20823

Once reviewed I can cherrypick this to CNV 2.2 release notes while it's still active, and to 2.3 as well since it looks like it's still a bug there as well.

Comment 3 Irina Gulina 2020-04-02 05:50:08 UTC

There is also missing export and single quotas around the CNV_CNANNEL. Then, the line should be: 

export TARGET_NAMESPACE=openshift-cnv CNV_CHANNEL=2.3 && oc patch -n "${TARGET_NAMESPACE}" $(oc get subscription -n ${TARGET_NAMESPACE} --no-headers -o name) --type='json' -p='[{"op": "replace", "path": "/spec/channel", "value":"'${CNV_CHANNEL}'"}, {"op": "replace", "path": "/spec/installPlanApproval", "value":"Automatic"}]'

Otherwise, it won't work:
$ TARGET_NAMESPACE=openshift-cnv CNV_CHANNEL=2.3 oc patch -n "${TARGET_NAMESPACE}" $(oc get subscription -n ${TARGET_NAMESPACE} --no-headers -o name) --type='json' -p='[{"op": "replace", "path": "/spec/channel", "value":"${CNV_CHANNEL}"}, {"op": "replace", "path": "/spec/installPlanApproval", "value":"Automatic"}]'
error: You must provide one or more resources by argument or filename.
Example resource specifications include:
   '-f rsrc.yaml'
   '--filename=rsrc.json'
   '<resource> <name>'
   '<resource>'
$ export TARGET_NAMESPACE=openshift-cnv CNV_CHANNEL=2.3 && oc patch -n "${TARGET_NAMESPACE}" $(oc get subscription -n ${TARGET_NAMESPACE} --no-headers -o name) --type='json' -p='[{"op": "replace", "path": "/spec/channel", "value":"${CNV_CHANNEL}"}, {"op": "replace", "path": "/spec/installPlanApproval", "value":"Automatic"}]'
subscription.operators.coreos.com/kubevirt-hyperconverged patched
[cloud-user@ocp-psi-executor ~]$ oc get subs -n openshift-cnv
NAME                      PACKAGE                   SOURCE             CHANNEL
kubevirt-hyperconverged   kubevirt-hyperconverged   redhat-operators   ${CNV_CHANNEL}

Comment 5 Andrew Burden 2020-04-02 07:49:29 UTC

Thanks for the extra info, Irina.

I've updated the PR as suggested:
https://github.com/openshift/openshift-docs/pull/20823/files

Comment 6 Nelly Credi 2020-04-13 08:49:14 UTC

TBH with the latest rebranding Im not sure using CNV is good
@Dan what do you think?

Comment 7 Dan Kenigsberg 2020-04-13 10:11:54 UTC

Rebranding is for next release only. And this is just a release note. I would not worry much about it.

We still don't have a properly-documented way to deploy OpenShift virtualization from the command line; even when we do, we can using upstream or cnv in the command line.

Comment 10 errata-xmlrpc 2020-05-04 19:10:58 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2020:2011