Bug 1820047

Summary:	[ansible-freeipa] Not able to remove usercat='all'/hostcat='all'/cmdcat='all' from sudorule in SUDO module
Product:	Red Hat Enterprise Linux 8	Reporter:	Varun Mylaraiah <mvarun>
Component:	ansible-freeipa	Assignee:	Rafael Jeffman <rjeffman>
Status:	CLOSED ERRATA	QA Contact:	ipa-qe <ipa-qe>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	8.2	CC:	amore, rjeffman, twoerner
Target Milestone:	rc	Flags:	pm-rhel: mirror+
Target Release:	8.0
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	ansible-freeipa-0.1.11-1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-11-04 02:46:35 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Varun Mylaraiah 2020-04-02 07:14:42 UTC

Description of problem:
There is option to remove usercat='all', hostcat='all', cmdcat='all' from sudorule in SUDO module

Version-Release number of selected component (if applicable):
ansible-freeipa-0.1.8-3.el8.noarch

Steps to Reproduce:
CLI-consule_output
==================
[root@master ~]# ipa sudorule-mod sudorule_1 --usercat="all" --hostcat="all"  --cmdcat='all'
-------------------------------
Modified Sudo Rule "sudorule_1"
-------------------------------
  Rule name: sudorule_1
  Enabled: TRUE
  User category: all
  Host category: all
  Command category: all

[root@master ~]# ipa sudorule-mod sudorule_1 --usercat="" --hostcat=""  --cmdcat=''
-------------------------------
Modified Sudo Rule "sudorule_1"
-------------------------------
  Rule name: sudorule_1
  Enabled: TRUE

Actual results:
no option available in ansible-freeipa Sudo module.

Expected results:
the option should available to reset/remove usercat='all', hostcat='all', --cmdcat='all' in sudorule module.

Comment 1 Rafael Jeffman 2020-04-08 11:48:49 UTC

Pull request in under review on upstream: https://github.com/freeipa/ansible-freeipa/pull/245

Comment 2 Rafael Jeffman 2020-05-13 13:36:41 UTC

PR merged upstream.

Comment 5 anuja 2020-07-27 08:07:49 UTC

Verified Using: 
Test from downstream ansible-freeipa-tests/ansible_freeipa_tests/sudo_module.py::Testsudorulecategoryall::()::test_add_sudorule_with_category_all
Using version: 
ansible-freeipa-0.1.12-5.el8.noarch
ipa-server-common-4.8.7-7.module+el8.3.0+7376+c83e4fcd.noarch

2020-07-27T08:02:03+0000 ----------- generated xml file: /home/jenkins/tews/trigger/junit.xml -----------
2020-07-27T08:02:03+0000 ------ generated html file: file:///home/jenkins/tews/trigger/report.html ------
2020-07-27T08:02:03+0000 ========================= 36 passed in 757.14 seconds ==========================
2020-07-27T08:02:03+0000 RETURN CODE: 0
2020-07-27T08:02:03+0000 UPSTREAM TESTS STEP END: ansible_freeipa_tests/sudo_module.py

Based on this marking bz as verified.

Comment 7 anuja 2020-07-27 12:36:53 UTC

Verified using: ansible_freeipa_tests/sudo_module.py::Testresetsudoruleall::test_sudorule_reset_categories 
Using version: 
ansible-freeipa-0.1.12-5.el8.noarch
ipa-server-common-4.8.7-7.module+el8.3.0+7376+c83e4fcd.noarch

2020-07-27T12:24:19+0000 ansible_freeipa_tests/sudo_module.py::Testresetsudoruleall::test_sudorule_reset_categories 
2020-07-27T12:24:19+0000 -------------------------------- live log call ---------------------------------
2020-07-27T12:24:19+0000 [pytest_multihost.host.Host.master.ParamikoTransport] INFO RUN ['ipactl', 'status']
2020-07-27T12:24:21+0000 [pytest_multihost.host.Host.master.ParamikoTransport] INFO RUN ['kinit', 'admin']
2020-07-27T12:24:21+0000 [pytest_multihost.host.Host.master.ParamikoTransport] INFO RUN ['ipa', 'sudorule-add', 'reset_sudo_rule', '--usercat=all', '--hostcat=all', '--cmdcat=all']
2020-07-27T12:24:22+0000 [pytest_multihost.host.Host.master.ParamikoTransport] INFO RUN ['kinit', 'admin']
2020-07-27T12:24:22+0000 [pytest_multihost.host.Host.master.ParamikoTransport] INFO RUN ['ipa', 'sudorule-show', 'reset_sudo_rule']
2020-07-27T12:24:23+0000 [pytest_multihost.host.Host.master.ParamikoTransport] INFO RUN ['kdestroy', '-A']
2020-07-27T12:24:23+0000 [pytest_multihost.host.Host.ansible.ParamikoTransport] INFO WRITE inventory/sudo.hosts
2020-07-27T12:24:23+0000 [pytest_multihost.host.Host.ansible.ParamikoTransport] INFO PUT sudo_module.yml
2020-07-27T12:24:23+0000 [pytest_multihost.host.Host.ansible.ParamikoTransport] INFO RUN ['ansible-playbook', '--ssh-extra-args="-o StrictHostKeyChecking=no"', '-vv', '-i', 'inventory/sudo.hosts', 'sudo_module.yml']
2020-07-27T12:24:28+0000 [pytest_multihost.host.Host.master.ParamikoTransport] INFO RUN ['kinit', 'admin']
2020-07-27T12:24:28+0000 [pytest_multihost.host.Host.master.ParamikoTransport] INFO RUN ['ipa', 'sudorule-show', 'reset_sudo_rule']
2020-07-27T12:24:29+0000 [pytest_multihost.host.Host.master.ParamikoTransport] INFO RUN ['kdestroy', '-A']
2020-07-27T12:24:29+0000 PASSED                                                                   [ 75%]

Based on this marking bz as verified.

Comment 11 errata-xmlrpc 2020-11-04 02:46:35 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (ansible-freeipa bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2020:4663