Bug 182063

Summary: Request to apply 4.4.3 ref count fix for Python Key() method to 4.4.2 RPM
Product: [Fedora] Fedora Reporter: Dennis Gregorovic <dgregor>
Component: rpmAssignee: Paul Nasrat <nobody+pnasrat>
Status: CLOSED RAWHIDE QA Contact: Mike McLean <mikem>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: pmatilai, redhat-bugzilla
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-06-26 07:52:04 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
patch from rpm 4.4.3 that fixes the reference counting in the Key() method none

Description Dennis Gregorovic 2006-02-20 02:18:33 UTC 
In rpm < 4.4.3 there is a bug in the Key() method of python/rpmte-py.c. In my
sample code, when Key() is called twice in a row, the following output is seen:

(<rpm.hdr object at 0xb79f33e0>, '../strace-4.5.11-1.i386.rpm')
(<refcnt 0 at 0xb79e1b8c>, '../strace-4.5.11-1.i386.rpm')

This causes the Key() method to not be usable.  However, I would like to have it
working in FC5 to facilitate the addition of transaction logging to Yum.  I'll
attach a patch from rpm-4.4.3 for consideration.
Comment 1 Dennis Gregorovic 2006-02-20 02:18:33 UTC 
Created attachment 124877 [details]
patch from rpm 4.4.3 that fixes the reference counting in the Key() method
Comment 2 Jeff Johnson 2006-02-20 22:43:48 UTC 
UPSTREAM so I don't have to stare at my own damn patches.
Comment 3 Paul Nasrat 2006-02-20 23:22:08 UTC 
Jeff please can you not close fedora bugs.
Comment 4 Jeff Johnson 2006-02-21 12:26:39 UTC 
This is also rpm bugzilla, and UPSTREAM is a valid closure.

Take away my bug closing privileges, and me and rpm are gone, if you wish bugzilla to be Fedora's only.

I find it quite ironic that my fix, and my patch delivered to dgregor, and my closing an rpm bug as 
UPSTREAM are somehow at odds with each other.
Comment 5 Paul Nasrat 2006-02-21 15:33:58 UTC 
If a bug is being filed against a Fedora or RHEL release, then although
CLOSED->UPSTREAM is accurate of the upstream state, I may still need to track
that bug against that release.
Comment 6 Panu Matilainen 2007-06-05 12:20:39 UTC 
Fix committed to rpm.org tree.
Comment 7 Panu Matilainen 2007-06-26 07:52:04 UTC 
Fixed in next rawhide push by rpm 4.4.2.1-rc1