Bug 1820907

Summary: [abrt] rawtherapee: std::__replacement_assert(char const*, int, char const*, char const*)(): rawtherapee killed by SIGABRT
Product: [Fedora] Fedora Reporter: Facundo <adscvr>
Component: rawtherapeeAssignee: Mattia Verga <mattia.verga>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 31CC: mattdm, mattia.verga, sebastian, thibault.north
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Unspecified   
URL: https://retrace.fedoraproject.org/faf/reports/bthash/c5f071fe6dac7cd91c2f36aca26cf44ed68aeef4
Whiteboard: abrt_hash:1652b6cab6085e4b1742727372d75d2de7eda974;VARIANT_ID=workstation;
Fixed In Version: rawtherapee-5.8-2.fc31 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-04-15 20:32:54 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
File: backtrace
none
File: core_backtrace
none
File: cpuinfo
none
File: dso_list
none
File: environ
none
File: limits
none
File: maps
none
File: mountinfo
none
File: open_fds
none
File: proc_pid_status none

Description Facundo 2020-04-04 15:24:11 UTC 
Description of problem:
1- Select files to export. Several files have been cropped. All are JPG.
2- Batch export them.
3- Program hangs.

The same thing happens sometimes when selecting some files and try to color mark them.

Version-Release number of selected component:
rawtherapee-5.8-1.fc31

Additional info:
reporter:       libreport-2.12.0
backtrace_rating: 4
cgroup:         0::/user.slice/user-1001.slice/user/gnome-launched-rawtherapee.desktop-30450.scope
cmdline:        rawtherapee
crash_function: std::__replacement_assert(char const*, int, char const*, char const*)
executable:     /usr/bin/rawtherapee
journald_cursor: s=02a1135e5fad4e2489bb21538d271a69;i=10e611;b=25a85e88958c498782fba78b9d2b03a5;m=5315e28ba;t=5a27856ce0691;x=8c5bc2cb147b9564
kernel:         5.5.13-200.fc31.x86_64
rootdir:        /
runlevel:       N 5
type:           CCpp
uid:            1001

Truncated backtrace:
Thread no. 1 (10 frames)
 #2 std::__replacement_assert(char const*, int, char const*, char const*) at /usr/include/c++/9/x86_64-redhat-linux/bits/c++config.h:2533
 #3 std::vector<Crop::CropRatio, std::allocator<Crop::CropRatio> >::operator[](unsigned long) at /usr/include/c++/9/bits/stl_vector.h:1042
 #4 Crop::read(rtengine::procparams::ProcParams const*, ParamsEdited const*) at /usr/src/debug/rawtherapee-5.8-1.fc31.x86_64/rtgui/crop.cc:357
 #5 BatchToolPanelCoordinator::initSession() at /usr/include/c++/9/bits/stl_vector.h:915
 #6 BatchToolPanelCoordinator::selectionChanged(std::vector<Thumbnail*, std::allocator<Thumbnail*> > const&) at /usr/src/debug/rawtherapee-5.8-1.fc31.x86_64/rtgui/batchtoolpanelcoord.cc:58
 #7 FileBrowser::notifySelectionListener() at /usr/src/debug/rawtherapee-5.8-1.fc31.x86_64/rtgui/filebrowser.cc:1931
 #8 FileBrowser::menuItemActivated(Gtk::MenuItem*) at /usr/src/debug/rawtherapee-5.8-1.fc31.x86_64/rtgui/filebrowser.cc:795
 #9 FileBrowser::keyPressed(_GdkEventKey*) at /usr/src/debug/rawtherapee-5.8-1.fc31.x86_64/rtgui/filebrowser.cc:1162
 #10 sigc::slot1<bool, _GdkEventKey*>::operator()(_GdkEventKey* const&) const at /usr/include/sigc++-2.0/sigc++/functors/slot_base.h:335
 #11 (anonymous namespace)::Widget_signal_key_press_event_callback(GtkWidget*, GdkEventKey*, void*) at widget.cc:1650
Comment 1 Facundo 2020-04-04 15:24:15 UTC 
Created attachment 1676228 [details]
File: backtrace
Comment 2 Facundo 2020-04-04 15:24:17 UTC 
Created attachment 1676229 [details]
File: core_backtrace
Comment 3 Facundo 2020-04-04 15:24:18 UTC 
Created attachment 1676230 [details]
File: cpuinfo
Comment 4 Facundo 2020-04-04 15:24:20 UTC 
Created attachment 1676231 [details]
File: dso_list
Comment 5 Facundo 2020-04-04 15:24:21 UTC 
Created attachment 1676232 [details]
File: environ
Comment 6 Facundo 2020-04-04 15:24:22 UTC 
Created attachment 1676233 [details]
File: limits
Comment 7 Facundo 2020-04-04 15:24:24 UTC 
Created attachment 1676234 [details]
File: maps
Comment 8 Facundo 2020-04-04 15:24:26 UTC 
Created attachment 1676235 [details]
File: mountinfo
Comment 9 Facundo 2020-04-04 15:24:27 UTC 
Created attachment 1676236 [details]
File: open_fds
Comment 10 Facundo 2020-04-04 15:24:29 UTC 
Created attachment 1676237 [details]
File: proc_pid_status
Comment 11 Mattia Verga 2020-04-04 16:23:48 UTC 
Is it ok for you if I make this ticket publicly available, so that I can share the backtrace with upstream developers?
Comment 12 Facundo 2020-04-04 16:44:46 UTC 
(In reply to Mattia Verga from comment #11)
> Is it ok for you if I make this ticket publicly available, so that I can
> share the backtrace with upstream developers?

Yes, sure! Go ahead. Thanks!
Comment 13 Mattia Verga 2020-04-05 16:44:53 UTC 
Upstream has provided a patch that should solve this issue. I have build a patched release in my COPR testing repository at https://copr.fedorainfracloud.org/coprs/mattia/Rawtherapee-test/

Can you install the latest build from there (either enabling the COPR repository or downloading the RPM) and test if you see any crash still?
Comment 14 Facundo 2020-04-05 18:39:37 UTC 
(In reply to Mattia Verga from comment #13)
> Upstream has provided a patch that should solve this issue. I have build a
> patched release in my COPR testing repository at
> https://copr.fedorainfracloud.org/coprs/mattia/Rawtherapee-test/
> 
> Can you install the latest build from there (either enabling the COPR
> repository or downloading the RPM) and test if you see any crash still?

Works fine! I have been using the build from COPR for more than an hour with not a single crash. Thanks!
Comment 15 Fedora Update System 2020-04-06 15:51:29 UTC 
FEDORA-2020-45854a5531 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-45854a5531
Comment 16 Fedora Update System 2020-04-07 03:10:05 UTC 
FEDORA-2020-45854a5531 has been pushed to the Fedora 31 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-45854a5531`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-45854a5531

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 17 Fedora Update System 2020-04-15 20:32:54 UTC 
FEDORA-2020-45854a5531 has been pushed to the Fedora 31 stable repository.
If problem still persists, please make note of it in this bug report.