Bug 1821037
| Summary: | Review Request: onednn - Deep Neural Network Library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nicolas Chauvet (kwizart) <kwizart> |
| Component: | Package Review | Assignee: | Hirotaka Wakabayashi <hiwkby> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | hiwkby, package-review |
| Target Milestone: | --- | Flags: | hiwkby:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-06-30 07:33:03 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Nicolas Chauvet (kwizart)
2020-04-05 15:10:00 UTC
Spec URL: http://dl.kwizart.net/review/onednn.spec SRPM URL: http://dl.kwizart.net/review/onednn-1.4-1.fc31.src.rpm koji scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=43562262 Hello Nicolas Sorry for my slow response. Please check the issues. Issues ====== License: field --------------- I think the license for this package must be "ASL 2.0, BSD, Boost and MIT" if this package includes files under the licenses described in THIRD-PARTY-PROGRAMS file and a comment right above the License: field should exist. Please see the following guideline: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_multiple_licensing_scenarios %license --------- I think THIRD-PARTY-PROGRAMS file must be included in %license if that file includes license text. Please see the following guideline: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text Reference ========= I manually reviewed this package since I couldn't review this package by using fedora-review because of build errors inside mock in my environment. Rpmlint results --------------- ``` $ rpmlint ~/rpmbuild/RPMS/x86_64/onednn-1.4-1.fc33.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint ~/rpmbuild/RPMS/x86_64/onednn-devel-1.4-1.fc33.x86_64.rpm onednn-devel.x86_64: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint ~/rpmbuild/SRPMS/onednn-1.4-1.fc33.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ``` sha256sum results ----------------- ``` $ wget https://github.com/oneapi-src/oneDNN//archive/v1.4/onednn-1.4.tar.gz && sha256sum onednn-1.4.tar.gz 54737bcb4dc1961d32ee75da3ecc529fa48198f8b2ca863a079e19a9c4adb70f onednn-1.4.tar.gz $ sha256sum ~/rpmbuild/SOURCES/onednn-1.4.tar.gz 54737bcb4dc1961d32ee75da3ecc529fa48198f8b2ca863a079e19a9c4adb70f /home/vagrant/rpmbuild/SOURCES/onednn-1.4.tar.gz ``` Koji ----- http://koji.fedoraproject.org/koji/taskinfo?taskID=44863550 Thanks in advance, Hirotaka Wakabayashi Spec URL: http://dl.kwizart.net/review/onednn.spec SRPM URL: http://dl.kwizart.net/review/onednn-1.5-1.fc31.src.rpm Changelog: Update to 1.5 Enable aarch64 (Improved license field) Thanks for the review Hello Nicolas, Thanks you for your fixes. Package approved. I manually reviewed this package since I couldn't review this package by using fedora-review because of build errors inside mock in my environment. Here are some logs of my manual review. Rpmlint results --------------- I successuflly built in my environment and run rpmlint. ``` $ rpmlint ~/rpmbuild/SRPMS/onednn-1.5-1.fc32.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint ~/rpmbuild/RPMS/x86_64/onednn-devel-1.5-1.fc32.x86_64.rpm onednn-devel.x86_64: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint ~/rpmbuild/RPMS/x86_64/onednn-debugsource-1.5-1.fc32.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint ~/rpmbuild/RPMS/x86_64/onednn-1.5-1.fc32.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint ~/rpmbuild/RPMS/x86_64/onednn-debuginfo-1.5-1.fc32.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ``` I successfully installed them and checked the licenses and other things to be checked. sha256sum results ----------------- ``` $ wget https://github.com/oneapi-src/oneDNN//archive/v1.5/onednn-1.5.tar.gz $ sha256sum onednn-1.5.tar.gz 2aacc00129418185e0bc1269d3ef82f93f08de2c336932989c0c360279129edb onednn-1.5.tar.gz $ sha256sum ~/rpmbuild/SOURCES/onednn-1.5.tar.gz 2aacc00129418185e0bc1269d3ef82f93f08de2c336932989c0c360279129edb /home/vagrant/rpmbuild/SOURCES/onednn-1.5.tar.gz ``` Koji ---- http://koji.fedoraproject.org/koji/taskinfo?taskID=46245691 Best, Hirotaka Wakabayashi (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/onednn Thanks for the review and scm. Closing. |