Bug 1821146

Summary: Missing asset files
Product: OpenShift Container Platform Reporter: Pawel Krupa <pkrupa>
Component: MonitoringAssignee: Paul Gier <pgier>
Status: CLOSED ERRATA QA Contact: hongyan li <hongyli>
Severity: low Docs Contact:
Priority: unspecified    
Version: 4.5CC: alegrand, anpicker, erooth, kakkoyun, lcosic, mloibl, pkrupa, surbania
Target Milestone: ---   
Target Release: 4.5.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-07-13 17:25:33 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Pawel Krupa 2020-04-06 07:20:06 UTC
Cluster-monitoring-operator repository is missing 2 generated asset files:
- assets/thanos-querier/kube-rbac-proxy-secret.yaml
- assets/thanos-ruler/kube-rbac-proxy-secret.yaml

Those files are referenced in pkg/manifests/manifests.go but not created in assets/ directory.

Those files need to exist or their references need to be removed from pkg/manifests/manifests.go.

Comment 1 Paul Gier 2020-04-06 17:10:58 UTC
The file assets/thanos-querier/kube-rbac-proxy-secret.yaml is still available and being used AFAICT.

The file assets/thanos-ruler/kube-rbac-proxy-secret.yaml was removed as part of a previous cleanup (https://github.com/openshift/cluster-monitoring-operator/pull/700).  Created PR #744 (https://github.com/openshift/cluster-monitoring-operator/pull/744)

Comment 4 hongyan li 2020-04-07 07:43:32 UTC
Test with payload 4.5.0-0.nightly-2020-04-06-212952:
Checked git repository:
- assets/thanos-querier/kube-rbac-proxy-secret.yaml exists
- assets/thanos-ruler/kube-rbac-proxy-secret.yaml   deleted

execute the following command and get the corresponding data:
oc get Secret thanos-querier-kube-rbac-proxy -oyaml

Comment 5 hongyan li 2020-04-07 08:05:13 UTC
Check git repository:
https://github.com/openshift/cluster-monitoring-operator

Comment 6 hongyan li 2020-04-07 08:54:59 UTC
enabled techPreviewUserWorkload, see
# oc -n openshift-monitoring get cm cluster-monitoring-config -oyaml
4:34
then there are resources under openshift-user-workload-monitoring
4:34
# oc -n openshift-user-workload-monitoring get secret | grep thanos-ruler
no kube-rbac-proxy secret

# oc -n openshift-monitoring get secret | grep thanos-querier
thanos-querier-dockercfg-r8szt                kubernetes.io/dockercfg               1      7h53m
thanos-querier-grpc-tls-f9g2c7s4l0rd9         Opaque                                3      7h53m
thanos-querier-kube-rbac-proxy                Opaque                                1      7h53m
thanos-querier-oauth-cookie                   Opaque                                1      7h54m
thanos-querier-oauth-htpasswd                 Opaque                                1      7h53m
thanos-querier-tls                            kubernetes.io/tls                     2      8h
thanos-querier-token-fvtzr                    kubernetes.io/service-account-token   4      7h53m
thanos-querier-token-vqjfj                    kubernetes.io/service-account-token   4      7h53m
There is secret thanos-querier-kube-rbac-proxy

Comment 7 errata-xmlrpc 2020-07-13 17:25:33 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2409