Bug 1821627

Summary: Creation of live snapshot of VM wirh RO disk fails - external snapshot for readonly disk sda is not supported
Product: [oVirt] ovirt-engine Reporter: Evelina Shames <eshames>
Component: BLL.StorageAssignee: Benny Zlotnik <bzlotnik>
Status: CLOSED CURRENTRELEASE QA Contact: Evelina Shames <eshames>
Severity: high Docs Contact:
Priority: unspecified    
Version: 4.4.0CC: aefrat, aoconnor, bugs, eshenitz, lsvaty, michal.skrivanek, tnisan
Target Milestone: ovirt-4.4.1Keywords: Automation, Regression
Target Release: 4.4.1.4Flags: pm-rhel: ovirt-4.4+
aoconnor: blocker+
aefrat: planning_ack?
aefrat: devel_ack?
aefrat: testing_ack+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: ovirt-engine-4.4.1.4 Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-07-08 08:24:43 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1832204    
Bug Blocks: 1759933    
Attachments:
Description Flags
logs none

Description Evelina Shames 2020-04-07 09:11:16 UTC
Created attachment 1676865 [details]
logs

Description of problem:
Creation of live snapshot of VM wirh RO disk fails with the following errors:

VDSM:
2020-04-07 11:34:30,795+0300 ERROR (virt/209906f8) [virt.vm] (vmId='144b3b7d-768e-4658-ac54-c4e32ff175c6') Unable to take snapshot (snapshot:463)
Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/vdsm/virt/jobs/snapshot.py", line 453, in snapshot
    self._vm.run_dom_snapshot(snapxml, snap_flags)
  File "/usr/lib/python3.6/site-packages/vdsm/virt/vm.py", line 5585, in run_dom_snapshot
    self._dom.snapshotCreateXML(snapxml, snap_flags)
  File "/usr/lib/python3.6/site-packages/vdsm/virt/virdomain.py", line 101, in f
    ret = attr(*args, **kwargs)
  File "/usr/lib/python3.6/site-packages/vdsm/common/libvirtconnection.py", line 131, in wrapper
    ret = f(*args, **kwargs)
  File "/usr/lib/python3.6/site-packages/vdsm/common/function.py", line 94, in wrapper
    return func(inst, *args, **kwargs)
  File "/usr/lib64/python3.6/site-packages/libvirt.py", line 2800, in snapshotCreateXML
    if ret is None:raise libvirtError('virDomainSnapshotCreateXML() failed', dom=self)
libvirt.libvirtError: unsupported configuration: external snapshot for readonly disk sda is not supported

Errors in engine log appears after ~30 min:
2020-04-07 12:04:35,307+03 ERROR [org.ovirt.engine.core.bll.snapshots.CreateLiveSnapshotForVmCommand] (EE-ManagedScheduledExecutorService-engineScheduledThreadPool-Thread-86) [42badbc4-77db-4aa9-b7a5-4513b8e8cf15] Ending command 'org.ovirt.engine.core.bll.snapshots.CreateLiveSnapshotForVmCommand' with failure.
2020-04-07 12:04:37,411+03 ERROR [org.ovirt.engine.core.bll.snapshots.CreateSnapshotForVmCommand] (EE-ManagedScheduledExecutorService-engineScheduledThreadPool-Thread-35) [42badbc4-77db-4aa9-b7a5-4513b8e8cf15] Ending command 'org.ovirt.engine.core.bll.snapshots.CreateSnapshotForVmCommand' with failure.
2020-04-07 12:04:37,522+03 ERROR [org.ovirt.engine.core.bll.snapshots.CreateSnapshotDiskCommand] (EE-ManagedScheduledExecutorService-engineScheduledThreadPool-Thread-35) [42badbc4-77db-4aa9-b7a5-4513b8e8cf15] Ending command 'org.ovirt.engine.core.bll.snapshots.CreateSnapshotDiskCommand' with failure.
2020-04-07 12:04:37,534+03 ERROR [org.ovirt.engine.core.bll.snapshots.CreateSnapshotCommand] (EE-ManagedScheduledExecutorService-engineScheduledThreadPool-Thread-35) [42badbc4-77db-4aa9-b7a5-4513b8e8cf15] Ending command 'org.ovirt.engine.core.bll.snapshots.CreateSnapshotCommand' with failure.
2020-04-07 12:04:37,554+03 ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.HSMRevertTaskVDSCommand] (EE-ManagedScheduledExecutorService-engineScheduledThreadPool-Thread-35) [42badbc4-77db-4aa9-b7a5-4513b8e8cf15] Trying to revert unknown task '2e8c401f-f6cc-423c-9e98-c23eebf3e21b'
2020-04-07 12:04:38,252+03 ERROR [org.ovirt.engine.core.bll.snapshots.CreateSnapshotCommand] (EE-ManagedScheduledExecutorService-engineScheduledThreadPool-Thread-35) [42badbc4-77db-4aa9-b7a5-4513b8e8cf15] Ending command 'org.ovirt.engine.core.bll.snapshots.CreateSnapshotCommand' with failure.
2020-04-07 12:04:38,270+03 ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.HSMRevertTaskVDSCommand] (EE-ManagedScheduledExecutorService-engineScheduledThreadPool-Thread-35) [42badbc4-77db-4aa9-b7a5-4513b8e8cf15] Trying to revert unknown task '2ec03ff8-985a-47c1-9a18-0dc53ae9281e'
2020-04-07 12:04:38,731+03 ERROR [org.ovirt.engine.core.bll.storage.disk.AddDiskCommand] (EE-ManagedScheduledExecutorService-engineScheduledThreadPool-Thread-35) [42badbc4-77db-4aa9-b7a5-4513b8e8cf15] Ending command 'org.ovirt.engine.core.bll.storage.disk.AddDiskCommand' with failure.
2020-04-07 12:04:38,743+03 ERROR [org.ovirt.engine.core.bll.storage.disk.image.AddImageFromScratchCommand] (EE-ManagedScheduledExecutorService-engineScheduledThreadPool-Thread-35) [42badbc4-77db-4aa9-b7a5-4513b8e8cf15] Ending command 'org.ovirt.engine.core.bll.storage.disk.image.AddImageFromScratchCommand' with failure.
2020-04-07 12:04:38,764+03 ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.HSMRevertTaskVDSCommand] (EE-ManagedScheduledExecutorService-engineScheduledThreadPool-Thread-35) [42badbc4-77db-4aa9-b7a5-4513b8e8cf15] Trying to revert unknown task '0f8297ed-6637-4ddb-a8e4-d8e101a18ee4'
2020-04-07 12:04:38,800+03 ERROR [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (EE-ManagedScheduledExecutorService-engineScheduledThreadPool-Thread-35) [] EVENT_ID: USER_ADD_DISK_FINISHED_FAILURE(2,022), Add-Disk operation failed to complete.
2020-04-07 12:04:38,813+03 ERROR [org.ovirt.engine.core.bll.storage.disk.image.AddImageFromScratchCommand] (EE-ManagedScheduledExecutorService-engineScheduledThreadPool-Thread-35) [42badbc4-77db-4aa9-b7a5-4513b8e8cf15] Ending command 'org.ovirt.engine.core.bll.storage.disk.image.AddImageFromScratchCommand' with failure.
2020-04-07 12:04:38,844+03 ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.HSMRevertTaskVDSCommand] (EE-ManagedScheduledExecutorService-engineScheduledThreadPool-Thread-35) [42badbc4-77db-4aa9-b7a5-4513b8e8cf15] Trying to revert unknown task 'c4bf39da-d00b-48a0-bb40-3fd999a49805'
2020-04-07 12:04:38,878+03 ERROR [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (EE-ManagedScheduledExecutorService-engineScheduledThreadPool-Thread-35) [] EVENT_ID: USER_ADD_DISK_FINISHED_FAILURE(2,022), Add-Disk operation failed to complete.
2020-04-07 12:04:38,910+03 ERROR [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (EE-ManagedScheduledExecutorService-engineScheduledThreadPool-Thread-35) [] EVENT_ID: USER_CREATE_SNAPSHOT_FINISHED_FAILURE(69), Failed to complete snapshot 's1' creation for VM 'golden_env_mixed_virtio_2_0'.


Version-Release number of selected component (if applicable):
vdsm-4.40.11-1.el8ev.x86_64
engine-4.4.0-0.31.master.el8ev

How reproducible:
100%

Steps to Reproduce:
1. Create VM with disk
2. Attach RO to the VM
3. Run VM
4. Try to take live snapshot

Actual results:
Operation fails, error appears on the UI after ~30 min.

Expected results:
Operation should succeed

Additional info:
Logs are attached.

Comment 1 Eyal Shenitzky 2020-04-13 14:13:45 UTC
Evelina, is this failed in the automation tests?

Comment 2 Eyal Shenitzky 2020-04-13 14:24:07 UTC
Banny is already working on it.
Evelina, please note that a snapshot for a RO disk is not supported anymore by Libvirt, so Benny is fixing it by ignoring the RO disks when taking a VM snapshot.

Comment 3 Evelina Shames 2020-04-13 15:00:18 UTC
(In reply to Eyal Shenitzky from comment #1)
> Evelina, is this failed in the automation tests?

The flow is manual flow but we have a test with LSM so live snapshot is part of it.

Comment 4 Avihai 2020-04-21 08:40:26 UTC
This is a regression for 4.4.
This same automation TestCase was tested and passed on rhv-4.3.6-9

Comment 5 RHEL Program Management 2020-04-21 08:40:33 UTC
This bug report has Keywords: Regression or TestBlocker.
Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.

Comment 6 Lukas Svaty 2020-04-21 10:04:43 UTC
Due to regression keyword targeting to closes release.

Comment 7 Michal Skrivanek 2020-06-05 18:41:20 UTC
dependent bug is fixed in AV 8.2.1, is there anything else to do?

Comment 8 Evelina Shames 2020-06-25 06:44:27 UTC
Verified on rhv-4.4.1-5

Comment 9 Sandro Bonazzola 2020-07-08 08:24:43 UTC
This bugzilla is included in oVirt 4.4.1 release, published on July 8th 2020.

Since the problem described in this bug report should be resolved in oVirt 4.4.1 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.