Bug 1821815

Summary: Review Request: golang-github-dop251-goja - ECMAScript 5.1(+) implementation
Product: [Fedora] Fedora Reporter: Fabian Affolter <mail>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: eclipseo, package-review
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-08-26 00:45:34 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1821809    
Bug Blocks: 201449    

Description Fabian Affolter 2020-04-07 16:45:58 UTC
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-dop251-goja.spec
SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-dop251-goja-0-0.1.20200407git6438c8d.fc31.src.rpm

Project URL: https://github.com/dop251/goja

Description:
ECMAScript 5.1(+) implementation written in Go.

Koji scratch build:
fails due to missing dependency

rpmlint output:
$ rpmlint golang-github-dop251-goja-0-0.1.20200407git6438c8d.fc31.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint golang-github-dop251-goja-devel-0-0.1.20200407git6438c8d.fc31.noarch.rpm
golang-github-dop251-goja-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/dop251/goja/.goipath
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

Fedora Account System Username: fab

Comment 1 Robert-André Mauchin 🐧 2020-06-20 16:12:59 UTC
LGTM

 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Package approved.

Comment 2 Mattia Verga 2021-07-26 13:16:41 UTC
Review stalled, resetting ticket status

Comment 3 Package Review 2021-08-26 00:45:34 UTC
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.