Bug 1821842

Summary: [UPSTREAM] V2V: Message logged for preflight check failure should be more specific when VM already exists on target provider
Product: Red Hat CloudForms Management Engine Reporter: Nandini Chandra <nachandr>
Component: V2VAssignee: Fabien Dupont <fdupont>
Status: CLOSED ERRATA QA Contact: Nandini Chandra <nachandr>
Severity: medium Docs Contact: Red Hat CloudForms Documentation <cloudforms-docs>
Priority: medium    
Version: unspecifiedCC: bthurber, dmetzger, simaishi
Target Milestone: GAKeywords: ZStream
Target Release: 5.11.6Flags: pm-rhel: cfme-5.11.z+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.11.6.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-06-10 13:39:10 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: V2V Target Upstream Version:
Embargoed:

Description Nandini Chandra 2020-04-07 17:33:54 UTC
Description of problem:
-----------------------
I ran into this issue while verifying https://bugzilla.redhat.com/show_bug.cgi?id=1809027 .

The following error was logged to the evm.log file, like expected.

 [----] E, [2020-04-02T19:00:01.312451 #8419:1209990] ERROR -- : Q-task_id([job_dispatcher]) MIQ(InfraConversionThrottler.start_conversions) Preflight check for auto-conv-rhv-vm2 has failed. Discarding. 

It would be great if the message logged could be more specific and stated the reason as to why the preflight check failed. 
A message like this would be very helpful to the end user and greatly reduce the time spent on troubleshooting the issue.
'A VM with the same name already existed on the target provider'.

It would also be nice if the reason for preflight check failure was shown in the CFME UI.


Version-Release number of selected component (if applicable):
-------------------------------------------------------------
master.20200403002716_63b3608c8d


How reproducible:
----------------
Always


Steps to Reproduce:
------------------
1.Add RHV and vSphere providers
2.Try Migrate a vSphere VM that already exists on RHV


Actual results:
---------------
Message logged for preflight check failure doesn't state the reason for failure.


Expected results:
-----------------
Message logged for preflight check failure should state the reason for failure.


Additional info:
----------------
I believe this issue is relevant to both OSP and RHV providers.

Comment 3 Nandini Chandra 2020-04-14 17:16:07 UTC
Ignore comment#2 . I meant to add that comment to another BZ.

Comment 4 Fabien Dupont 2020-05-07 10:35:22 UTC
https://github.com/ManageIQ/manageiq/pull/20134

Comment 5 CFME Bot 2020-05-13 14:20:23 UTC
New commit detected on ManageIQ/manageiq/ivanchuk:

https://github.com/ManageIQ/manageiq/commit/6b7fdccc147a94c40be38c9e09737296a72c026b
commit 6b7fdccc147a94c40be38c9e09737296a72c026b
Author:     Adam Grare <agrare>
AuthorDate: Fri May  8 12:44:36 2020 +0000
Commit:     Adam Grare <agrare>
CommitDate: Fri May  8 12:44:36 2020 +0000

    Merge pull request #20134 from fdupont-redhat/v2v_bz_1821842

    [V2V] Add error message in log when preflight check fails

    (cherry picked from commit ccacc45cc42c0161b42c9c11523446628b56ec37)

    https://bugzilla.redhat.com/show_bug.cgi?id=1821842

 lib/infra_conversion_throttler.rb | 2 +-
 spec/lib/infra_conversion_throttler_spec.rb | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

Comment 6 CFME Bot 2020-05-13 14:25:19 UTC
New commit detected on ManageIQ/manageiq/jansa:

https://github.com/ManageIQ/manageiq/commit/d48c6e126a15468bbb67ee08a1f408a05bc4e19f
commit d48c6e126a15468bbb67ee08a1f408a05bc4e19f
Author:     Adam Grare <agrare>
AuthorDate: Fri May  8 12:44:36 2020 +0000
Commit:     Adam Grare <agrare>
CommitDate: Fri May  8 12:44:36 2020 +0000

    Merge pull request #20134 from fdupont-redhat/v2v_bz_1821842

    [V2V] Add error message in log when preflight check fails

    (cherry picked from commit ccacc45cc42c0161b42c9c11523446628b56ec37)

    https://bugzilla.redhat.com/show_bug.cgi?id=1821842

 lib/infra_conversion_throttler.rb | 2 +-
 spec/lib/infra_conversion_throttler_spec.rb | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

Comment 7 Nandini Chandra 2020-05-29 16:23:57 UTC
Verified in 5.11.6

With the fix, I see this message logged to evm.log
[----] E, [2020-05-29T12:17:04.063097 #6563:2b0930dc05b4] ERROR -- : Q-task_id([job_dispatcher]) MIQ(InfraConversionThrottler.start_conversions) Preflight check for nachandr-miq-s has failed: A VM named 'nachandr-miq-s' already exist in destination cluster. Discarding.

I also see this message in the UI(see attached screen shot)
Migration failed: A VM named 'nachandr-miq-s' already exist in destination cluster. Cancelling: Migration cancelled

Comment 10 errata-xmlrpc 2020-06-10 13:39:10 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:2480