Bug 1822121

Summary:	Filter /dev/mapper/x devices, when provided with blacklist_gluster_devices option enabled
Product:	[oVirt] cockpit-ovirt	Reporter:	SATHEESARAN <sasundar>
Component:	gluster-ansible	Assignee:	Parth Dhanjal <dparth>
Status:	CLOSED CURRENTRELEASE	QA Contact:	SATHEESARAN <sasundar>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	0.14.3	CC:	bugs, godas, rhs-bugs
Target Milestone:	ovirt-4.4.0	Flags:	sasundar: ovirt-4.4? sasundar: planning_ack? godas: devel_ack+ sasundar: testing_ack?
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	cockpit-ovirt-0.14.5	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1822120	Environment:
Last Closed:	2020-05-20 20:02:48 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Gluster	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1822120

Description SATHEESARAN 2020-04-08 10:13:28 UTC

Description of problem:
-----------------------
Technically, when the user enables 'blacklist gluster devices' option, the devices should be of format /dev/sdx. But there are chances, users could provide insane values or provide LUKS devices ( /dev/mapper/luks_sdb ) those were created via executing ansible playbook

In this case, when 'blacklist gluster devices' is enabled and user provides device values as /dev/mapper/x, do not add those devices under 'blacklist_mpath_devices' in the generated inventory file

Version-Release number of selected component (if applicable):
--------------------------------------------------------------
cockpit-ovirt-dashboard-0.14.3

How reproducible:
-----------------
Always

Steps to Reproduce:
--------------------
1. Start RHHI-V/HC deployment from web console
2. On the 'bricks' tab, enable the option 'Blacklist Gluster Devices', which is selected by default
3. Provide disk values as /dev/mapper/luks_sdb

Actual results:
----------------
Generated inventory file contains luks_sdb


Expected results:
-----------------
Generated inventory file should not contain luks_sdb



Additional info:

Comment 1 SATHEESARAN 2020-05-06 17:08:16 UTC

Tested with cockpit-ovirt-dashboard-0.14.5

When the device name is provided as /dev/mapper/luks_sdb, and that device is not
added to the 'blacklist_mpath_devices' in the generated inventory file.

There is one known issue in this context.
When there are less than 3 bricks devices are to be blacklisted, an empty ''
is added to the list of devices to blacklisted, but just gets skipped and doesn't
impact the deployment. So this issue is ignored

Comment 2 Sandro Bonazzola 2020-05-20 20:02:48 UTC

This bugzilla is included in oVirt 4.4.0 release, published on May 20th 2020.

Since the problem described in this bug report should be
resolved in oVirt 4.4.0 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.