Bug 1822142
| Summary: | Review Request: golang-github-chromedp - Drive browsers supporting the Chrome DevTools Protocol | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabian Affolter <mail> |
| Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <eclipseo> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | eclipseo, package-review, quantum.analyst |
| Target Milestone: | --- | Flags: | eclipseo:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-09-25 17:00:14 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1821419, 1821746 | ||
| Bug Blocks: | 1822145, 1866183 | ||
|
Description
Fabian Affolter
2020-04-08 11:09:13 UTC
Remove the extraneous %files spection - License ok - Latest version packaged - Builds in mock - Conforms to Packaging Guidelines Package approved. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-chromedp PS, can you build for all releases? This should have a runtime dependency on `chromium`, or you can't run tests in dependent packages without specifying it also. Or if you want to allow real chrome for people in RPMfusion, then a Recommends instead.
%global godevelheader %{expand:
Requires: chromium}
Also, you have %files for the (no-suffix) main package, but it's empty and doesn't have any additional Requires. I don't think it's necessary to produce that main package. FEDORA-2020-71c410f165 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-71c410f165 FEDORA-2020-df3d194a14 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-df3d194a14 FEDORA-2020-b313edba5f has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-b313edba5f FEDORA-2020-b313edba5f has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-b313edba5f \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-b313edba5f See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2020-71c410f165 has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-71c410f165 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-71c410f165 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2020-df3d194a14 has been pushed to the Fedora 33 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-df3d194a14 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-df3d194a14 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2020-df3d194a14 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2020-b313edba5f has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2020-71c410f165 has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. |