Bug 1822561
| Summary: | Review Request: wget2 - the successor of GNU Wget, a file and recursive website downloader | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Anna Khaitovich <akhaitov> |
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> |
| Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | lemenkov, ngompa13, package-review |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-09-26 15:00:53 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Anna Khaitovich
2020-04-09 10:42:21 UTC
Provides: libtool
Provides: wget2-debugsource = 1.99.2-1
Provides: wget2-debuginfo = 1.99.2-1
# Versioned libraries
Provides: libwget.so.0
Provides: libwget_alloc.so.0
Provides: libwget_common.so.0
Provides: libwget_css.so.0
Provides: libwget_dns.so.0
Provides: libwget_dnscache.so.0
Provides: libwget_encoding.so.0
Provides: libwget_hashfile.so.0
Provides: libwget_hpkp_db.so.0
Provides: libwget_ip.so.0
Provides: libwget_iri.so.0
Provides: libwget_logger.so.0
Provides: libwget_metalink.so.0
^^^ This looks wrong. Please remove it.
%{_libdir}/libwget*.a
%{_libdir}/libwget*.la
^^^ These files shouldn't be packaged.
Also you likely mean devel sub-packages of these packages, not the packages itself: BuildRequires: glibc BuildRequires: zlib >= 1.2.3 BuildRequires: gnutls BuildRequires: libidn2 >= 0.14 BuildRequires: flex >= 2.5.35 BuildRequires: libpsl >= 0.5.0 # Optional # HTTP/2 support BuildRequires: libnghttp2 >= 1.3.0 # run the test suite BuildRequires: libmicrohttpd >= 0.9.51 # build distribution tarballs BuildRequires: lzip # coverage reports BuildRequires: lcov # automatic signature verification) BuildRequires: gpgme >= 0.4.2 # filtering by PCRE regex BuildRequires: pcre # HTTP zstd decompression) BuildRequires: libzstd >= 1.3.0 Taking this review. New spec: https://download.copr.fedorainfracloud.org/results/akhaitov/wget2/fedora-rawhide-x86_64/01338615-wget2/wget2.spec New srpm: https://download.copr.fedorainfracloud.org/results/akhaitov/wget2/fedora-rawhide-x86_64/01338615-wget2/wget2-1.99.2-1.fc33.src.rpm Regarding wget2-static - will discuss with upstream if those extra static libraries are indeed needed This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time, but it seems that the review is still being working out by you. If this is right, please respond to this comment clearing the NEEDINFO flag and try to reach out the submitter to proceed with the review. If you're not interested in reviewing this ticket anymore, please clear the fedora-review flag and reset the assignee, so that a new reviewer can take this ticket. Without any reply, this request will shortly be resetted. Anna, we don't generally ship libtool archives, so those should be deleted. The end result would be that we wouldn't have a -static subpackage. Please delete libtool archives and remove the -static subpackage. See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#packaging-static-libraries As Anna no longer works at Red Hat and cannot be contacted, this review is effectively dead and superseded by a new one. *** This bug has been marked as a duplicate of bug 2007965 *** |