Bug 1822949

Summary:	Review Request: golang-github-parnurzeal-gorequest - Simplified HTTP client
Product:	[Fedora] Fedora	Reporter:	Fabian Affolter <mail>
Component:	Package Review	Assignee:	Robert-André Mauchin 🐧 <eclipseo>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	eclipseo, package-review
Target Milestone:	---	Flags:	eclipseo: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-08-22 19:29:14 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1822947
Bug Blocks:	1822954

Description Fabian Affolter 2020-04-10 15:40:15 UTC

Spec URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-parnurzeal-gorequest.spec
SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-parnurzeal-gorequest-0.2.16-1.fc31.src.rpm

Project URL: https://github.com/parnurzeal/gorequest

Description:
GoRequest is a simplified HTTP client.

Koji scratch build:
fails due to missing dependency

rpmlint output:
$ rpmlint golang-github-parnurzeal-gorequest-0.2.16-1.fc31.src.rpm 
golang-github-parnurzeal-gorequest.src: W: no-%build-section
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

$ rpmlint golang-github-parnurzeal-gorequest-devel-0.2.16-1.fc31.noarch.rpm 
golang-github-parnurzeal-gorequest-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/parnurzeal/gorequest/.goipath
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

Fedora Account System Username: fab

Comment 1 Robert-André Mauchin 🐧 2020-06-21 14:48:37 UTC

 - I've got error in tests:

Testing    in: /builddir/build/BUILD/gorequest-0.2.16/_build/src
         PATH: /builddir/build/BUILD/gorequest-0.2.16/_build/bin:/usr/lib64/ccache:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/sbin
       GOPATH: /builddir/build/BUILD/gorequest-0.2.16/_build:/usr/share/gocode
  GO111MODULE: off
      command: go test -buildmode pie -compiler gc -ldflags "-X github.com/parnurzeal/gorequest/version=0.2.16 -extldflags '-Wl,-z,relro -Wl,--as-needed  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld '"
      testing: github.com/parnurzeal/gorequest
github.com/parnurzeal/gorequest
2020/06/21 14:41:49 http: Accept error: accept tcp 127.0.0.1:42743: accept4: too many open files; retrying in 5ms
2020/06/21 14:41:49 http: Accept error: accept tcp 127.0.0.1:42743: accept4: too many open files; retrying in 5ms
--- FAIL: TestTimeoutFunc (2.01s)
    gorequest_test.go:2091: Expected timeout in between 1000 -> 1500 ms | but got 4907426
--- FAIL: TestCookies (0.00s)
    gorequest_test.go:2129: Cookies test request did not complete
FAIL
exit status 1
FAIL	github.com/parnurzeal/gorequest	2.405s


 Seems it's network related so maybe it can't work in Mock. Otherwise LGTM:

 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Package approved.

Comment 2 Gwyn Ciesla 2020-06-24 13:34:29 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-parnurzeal-gorequest