Bug 1823151
| Summary: | Review Request: thinkpad-tools - Tools to manage ThinkPad properties | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Dev Singh <dev> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | mail, mattdm, package-review, zebob.m |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-07-17 13:01:44 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 177841 | ||
|
Description
Dev Singh
2020-04-12 00:58:12 UTC
Just some comments to get started... - URL field is empty -> https://github.com/devksingh4/thinkpad-tools - Source0 could be %{pypi_source} - The descriptions should end with a period. - LICENSE file must be added to the %files section (%license LICENSE) - /etc/thinkpad-tools-persistence.sh looks misplaced, only configuration files should go under /etc https://docs.fedoraproject.org/en-US/packaging-guidelines/#_configuration_files - Systemd unit files: https://docs.fedoraproject.org/en-US/packaging-guidelines/Systemd/#_packaging - Changelog is missing Also, https://github.com/devksingh4/thinkpad-tools/issues/14 should be addressed. Hello Fabian, Thank you for your comments. I have addressed all of them, however, I believe that the persistence bash script is in the correct place. While it is a bash script, it's really a config file for the user to specify what settings should be applied on startup. Do you have another location in mind for this file? I have also added the package to a COPR for Fedora/CentOS here: https://copr.fedorainfracloud.org/coprs/dsingh/thinkpad-tools/ Mightn't it be better to use a proper config file syntax for the persistent settings rather than a bash script? That's really an upstream issue rather than something for package review, though. (Also, along the same lines: thinkpad-tools.service should maybe be `oneshot` rather than `simple`, since it's not a daemon.) I'll file these upstream. Removing "needinfo"... - Missing systemD scriptlets: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_systemd - /usr/lib/systemd/system/thinkpad-tools.service → %{_unitdir}/thinkpad-tools.service - Separate your changelog entries by a new line - Since you provide a binary, consider instead naming your package "thinkpad-tools" with no Python3 subpackage - Up to upstream, but generally configuration files are named *.conf not *.ini. This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience. |