Bug 1823919

Summary:	WSU fails as OVN hybrid naming has changed
Product:	OpenShift Container Platform	Reporter:	Aravindh Puthiyaparambil <aravindh>
Component:	Windows Containers	Assignee:	ravig <rgudimet>
Status:	CLOSED ERRATA	QA Contact:	gaoshang <sgao>
Severity:	urgent	Docs Contact:
Priority:	urgent
Version:	4.5	CC:	aos-bugs, aravindh, gmarkley, rgudimet, sgao
Target Milestone:	---
Target Release:	4.5.0
Hardware:	All
OS:	All
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1823579
Clones:	1833441 (view as bug list)		Environment:
Last Closed:	2020-07-13 17:27:24 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1833441

Description Aravindh Puthiyaparambil 2020-04-14 19:27:23 UTC

+++ This bug was initially created as a clone of Bug #1823579 +++

Description of problem:

Because of this commit https://github.com/openshift/ovn-kubernetes/commit/2563e6b82827726cd7850ed2824346a6ae5ba5eb#diff-86eeef0b956d450bd2a787067b7443fdR26 in onv-kubernetes repo, the hybrid-overlay binary is no longer called hybrid-overlay.exe but it is called hybrid-overlay-node.exe. We've a hardcoding to hybrid-overlay.exe in WSU. The name of this binary needs to be changed for WSU to start working. In addition the HNS networks created by the hybrid overlay has changed and we need to react to that to. We also need to stop patching the network.operator cluster CR in the e2e tests for them to pass.


How reproducible: always


Steps to Reproduce:
1. Run the WSU
2. 
3.

Actual results: Fails to add a Windows node to the cluster.


Expected results: Adds Windows node to the cluster.


Additional info:

Comment 3 gaoshang 2020-05-06 07:49:22 UTC

This bug has been verified and passed on OCP 4.5.0-0.nightly-2020-05-05-205255, thanks.

Steps: 

1, Bring up the OpenShift cluster 4.5.0-0.nightly-2020-05-05-205255 with ovn-kubernetes, details steps please see page 2 in https://view.highspot.com/viewer/5ea85b84628ba23c211217ba?iid=5ea85aaac79c522018df4100

2, Bring up Windows node
# ./wni aws create --kubeconfig cluster/auth/kubeconfig --credentials ~/.aws/credentials --credential-account default --instance-type m5a.large --ssh-key openshift-qe --private-key ~/.ssh/openshift-qe.pem

3, Configure inventory file and run wsu, check Windows node bootstrapped
# ansible-playbook -i hosts ~/go/src/windows-machine-config-bootstrapper/tools/ansible/tasks/wsu/main.yaml -v
...
PLAY RECAP ******
3.21.56.206                : ok=34   changed=26   unreachable=0    failed=0    skipped=4    rescued=0    ignored=1   
localhost                  : ok=27   changed=24   unreachable=0    failed=0    skipped=3    rescued=0    ignored=0  

# oc get node -l kubernetes.io/os=windows
NAME                                       STATUS   ROLES    AGE   VERSION
ip-10-0-37-34.us-east-2.compute.internal   Ready    worker   52m   v1.18.0-rc.1

4, RDP into Windows node, pull docker image, then check Windows workload available
> docker pull mcr.microsoft.com/windows/servercore:ltsc2019

# oc create -f https://raw.githubusercontent.com/sgaoshang/winc-test/master/data/WinWebServer.yaml -n default

# oc get service -n default
NAME              TYPE           CLUSTER-IP       EXTERNAL-IP                                                              PORT(S)        AGE
kubernetes        ClusterIP      172.30.0.1       <none>                                                                   443/TCP        140m
openshift         ExternalName   <none>           kubernetes.default.svc.cluster.local                                     <none>         129m
win-webserver     LoadBalancer   172.30.172.185   a51142f76623e40269ae7d3b078241b3-637144010.us-east-2.elb.amazonaws.com   80:32193/TCP   33m

# curl a51142f76623e40269ae7d3b078241b3-637144010.us-east-2.elb.amazonaws.com:80
<html><body><H1>Windows Container Web Server</H1><p>IP 10.132.0.3 callerCount 1 <p>IP 10.132.0.3 callerCount 1 </body></html>

Comment 4 errata-xmlrpc 2020-07-13 17:27:24 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2409