Bug 1825235
| Summary: | [azure] Machine status should be "Failed" with an invalid configuration | ||
|---|---|---|---|
| Product: | OpenShift Container Platform | Reporter: | Joel Speed <jspeed> |
| Component: | Cloud Compute | Assignee: | Joel Speed <jspeed> |
| Cloud Compute sub component: | Other Providers | QA Contact: | Jianwei Hou <jhou> |
| Status: | CLOSED ERRATA | Docs Contact: | |
| Severity: | medium | ||
| Priority: | medium | CC: | agarcial, jspeed, zhsun |
| Version: | 4.5 | ||
| Target Milestone: | --- | ||
| Target Release: | 4.5.0 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: |
Cause: Errors returned from the cloud-provider actuator no longer matched the expected type due to being wrapped using github.com/pkg/errors
Consequence: The Machine controller could not determine that the Machine should be marked as failed
Fix: Use error wrapping from the standard library to check the error types
Result: Machine controller can now determine when Machines should be marked Failed
|
Story Points: | --- |
| Clone Of: | 1824497 | Environment: | |
| Last Closed: | 2020-07-13 17:28:32 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1824497 | ||
| Bug Blocks: | |||
|
Description
Joel Speed
2020-04-17 13:06:10 UTC
This issue is also present in the Azure provider, will block this on the AWS provider All PRs are merged. Seems automation failed to update status. Setting to modified Verified
Create a machineset with invalid image, machine goes into phase "Failed".
$ oc get machine
NAME PHASE TYPE REGION ZONE AGE
zhsunazure428-jvwvn-master-0 Running Standard_D8s_v3 westus 3h53m
zhsunazure428-jvwvn-master-1 Running Standard_D8s_v3 westus 3h53m
zhsunazure428-jvwvn-master-2 Running Standard_D8s_v3 westus 3h53m
zhsunazure428-jvwvn-worker-westus-invalid-kw2sc Failed 59s
zhsunazure428-jvwvn-worker-westus-wz74f Running Standard_D2s_v3 westus 3h43m
zhsunazure428-jvwvn-worker-westus-xxjdx Running Standard_D2s_v3 westus 3h43m
E0428 06:36:28.616435 1 actuator.go:79] Machine error: failed to reconcile machine "zhsunazure428-jvwvn-worker-westus-invalid-kw2sc": compute.VirtualMachinesClient#CreateOrUpdate: Failure sending request: StatusCode=404 -- Original Error: Code="NotFound" Message="The Image '/subscriptions/53b8f551-f0fc-4bea-8cba-6d1fefd54c8a/resourceGroups/zhsunazure428-jvwvn-rg/providers/Microsoft.Compute/images/zhsunazure428-jvwvn-invalid' cannot be found in 'westus' region."
W0428 06:36:28.616526 1 controller.go:312] zhsunazure428-jvwvn-worker-westus-invalid-kw2sc: failed to create machine: failed to reconcile machine "zhsunazure428-jvwvn-worker-westus-invalid-kw2sc": compute.VirtualMachinesClient#CreateOrUpdate: Failure sending request: StatusCode=404 -- Original Error: Code="NotFound" Message="The Image '/subscriptions/53b8f551-f0fc-4bea-8cba-6d1fefd54c8a/resourceGroups/zhsunazure428-jvwvn-rg/providers/Microsoft.Compute/images/zhsunazure428-jvwvn-invalid' cannot be found in 'westus' region."
I0428 06:36:28.616564 1 controller.go:412] Actuator returned invalid configuration error: failed to reconcile machine "zhsunazure428-jvwvn-worker-westus-invalid-kw2sc": compute.VirtualMachinesClient#CreateOrUpdate: Failure sending request: StatusCode=404 -- Original Error: Code="NotFound" Message="The Image '/subscriptions/53b8f551-f0fc-4bea-8cba-6d1fefd54c8a/resourceGroups/zhsunazure428-jvwvn-rg/providers/Microsoft.Compute/images/zhsunazure428-jvwvn-invalid' cannot be found in 'westus' region."
I0428 06:36:28.616581 1 controller.go:421] zhsunazure428-jvwvn-worker-westus-invalid-kw2sc: going into phase "Failed"
I0428 06:36:28.616544 1 recorder.go:52] controller-runtime/manager/events "msg"="Warning" "message"="InvalidConfiguration: failed to reconcile machine \"zhsunazure428-jvwvn-worker-westus-invalid-kw2sc\": compute.VirtualMachinesClient#CreateOrUpdate: Failure sending request: StatusCode=404 -- Original Error: Code=\"NotFound\" Message=\"The Image '/subscriptions/53b8f551-f0fc-4bea-8cba-6d1fefd54c8a/resourceGroups/zhsunazure428-jvwvn-rg/providers/Microsoft.Compute/images/zhsunazure428-jvwvn-invalid' cannot be found in 'westus' region.\"" "object"={"kind":"Machine","namespace":"openshift-machine-api","name":"zhsunazure428-jvwvn-worker-westus-invalid-kw2sc","uid":"eff0a38b-2b3d-4398-b3a8-34e026d75fbc","apiVersion":"machine.openshift.io/v1beta1","resourceVersion":"105848"} "reason"="FailedCreate"
I0428 06:36:28.637427 1 controller.go:282] controller-runtime/controller "msg"="Successfully Reconciled" "controller"="machine_controller" "request"={"Namespace":"openshift-machine-api","Name":"zhsunazure428-jvwvn-worker-westus-invalid-kw2sc"}
I0428 06:36:28.637499 1 controller.go:166] zhsunazure428-jvwvn-worker-westus-invalid-kw2sc: reconciling Machine
W0428 06:36:28.637517 1 controller.go:263] zhsunazure428-jvwvn-worker-westus-invalid-kw2sc: machine has gone "Failed" phase. It won't reconcile
I0428 06:36:28.637540 1 controller.go:282] controller-runtime/controller "msg"="Successfully Reconciled" "controller"="machine_controller" "request"={"Namespace":"openshift-machine-api","Name":"zhsunazure428-jvwvn-worker-westus-invalid-kw2sc"}
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2020:2409 |