Bug 1826100

Summary:	vSphere IPI - Platform and cloud provider read Folder but machine creation still using clusterID
Product:	OpenShift Container Platform	Reporter:	davis phillips <dphillip>
Component:	Installer	Assignee:	Patrick Dillon <padillon>
Installer sub component:	openshift-installer	QA Contact:	jima
Status:	CLOSED ERRATA	Docs Contact:
Severity:	high
Priority:	high	CC:	adahiya, jcallen, jima
Version:	4.5
Target Milestone:	---
Target Release:	4.5.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:	Cause: the cloud provider config was always populated with a folder named after the cluster name Consequence: in clusters with a folder that was not named after cluster name, machine API would error with incorrect folder Fix: update cloud provider config to use the specified folder name Result: machine api can properly create workers in correct folder	Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-07-13 17:29:33 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description davis phillips 2020-04-20 21:28:48 UTC

Description of problem:


Client Version: 4.5.0-0.nightly-2020-04-17-114625
Server Version: 4.5.0-0.nightly-2020-04-17-114625
Kubernetes Version: v1.18.0-rc.1
[root@rh8-tools ipi]# ./openshift-install version
./openshift-install 4.5.0-0.nightly-2020-04-17-114625
built from commit 19d22e67d372145f24bed3030aa049da9ebc398e
release image quay.io/openshift-release-dev/ocp-release-nightly@sha256:2357cbed27ba57912fc92392ef7cacb1a79546587946771ab6a71fbf397056a3

Platform and Cloudprovider now use Folder from install-config, however machine workspace is set to ClusterID

https://github.com/openshift/installer/blob/c904277e59dd947a8884265b2511034b05c38644/pkg/asset/machines/vsphere/machines.go#L86

How reproducible:

Steps to Reproduce:
1. Create install-config and deploy via "openshift create cluster"
2. VMs are created in foldernamed $CLUSTERID
3. VM cloud providers uses the correct path

Actual results:
VMs are created in foldernamed $CLUSTERID

Expected results:
Cloud provider and machine creation use same platform

Comment 1 Abhinav Dahiya 2020-04-27 17:43:58 UTC

*** Bug 1825954 has been marked as a duplicate of this bug. ***

Comment 2 jima 2020-05-13 08:31:39 UTC

Verified on nightly build: 4.5.0-0.nightly-2020-05-13-014437, cluster is created under provided sub-folder, and also test to scaleup workers and destroy clusters, all works well.

# ../oc describe machineset -n openshift-machine-api jima1826100-bjjbb-worker
.....
Spec:
  Replicas:  3
  Selector:
    Match Labels:
      machine.openshift.io/cluster-api-cluster:     jima1826100-bjjbb
      machine.openshift.io/cluster-api-machineset:  jima1826100-bjjbb-worker
  Template:
    Metadata:
      Labels:
        machine.openshift.io/cluster-api-cluster:       jima1826100-bjjbb
        machine.openshift.io/cluster-api-machine-role:  worker
        machine.openshift.io/cluster-api-machine-type:  worker
        machine.openshift.io/cluster-api-machineset:    jima1826100-bjjbb-worker
    Spec:
      Metadata:
      Provider Spec:
        Value:
          API Version:  vsphereprovider.openshift.io/v1beta1
          Credentials Secret:
            Name:       vsphere-cloud-credentials
          Disk Gi B:    50
          Kind:         VSphereMachineProviderSpec
          Memory Mi B:  8192
          Metadata:
            Creation Timestamp:  <nil>
          Network:
            Devices:
              Network Name:      VM Network
          Num CP Us:             4
          Num Cores Per Socket:  2
          Snapshot:              
          Template:              jima1826100-bjjbb-rhcos
          User Data Secret:
            Name:  worker-user-data
          Workspace:
            Datacenter:  dc1
            Datastore:   10TB-GOLD
            Folder:      /dc1/vm/jima/jima1826100
            Server:      vcsa2-qe.vmware.devcluster.openshift.com
Status:
  Available Replicas:      3
  Fully Labeled Replicas:  3
  Observed Generation:     2
  Ready Replicas:          3
  Replicas:                3
Events:                    <none>

Comment 4 errata-xmlrpc 2020-07-13 17:29:33 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2409