Bug 1826141

Summary: egl-wayland: does not rebuild with mesa-19.3.0-3.rc4.el8
Product: Red Hat Enterprise Linux 8 Reporter: Carl George 🤠 <carl>
Component: egl-waylandAssignee: Adam Jackson <ajax>
Status: CLOSED ERRATA QA Contact: Desktop QE <desktop-qa-list>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: CentOS StreamCC: bstinson, carl, jwboyer, mark, ngompa13, tpelka
Target Milestone: rcKeywords: OtherQA
Target Release: 8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: egl-wayland-1.1.5-3.el8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-05-18 15:39:26 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
add EGL_WL_bind_wayland_display definitions to wayland-egl-ext.h none

Description Carl George 🤠 2020-04-21 03:27:07 UTC
Description of problem:
Rebuilding egl-wayland-1.1.4-1.el8 [0] with mesa-19.3.0-3.rc4.el8 [1] fails.  I ran into this attempting to build these NVRs for CentOS Stream.  Digging into the issue, I found this error in the build log [2].

../src/wayland-eglsurface.c: In function 'wlEglQueryNativeResourceHook':
../src/wayland-eglsurface.c:1521:10: error: 'EGL_WAYLAND_Y_INVERTED_WL' undeclared (first use in this function); did you mean 'EGL_WAYLAND_EGLSTREAM_WL'?
     case EGL_WAYLAND_Y_INVERTED_WL:
          ^~~~~~~~~~~~~~~~~~~~~~~~~
          EGL_WAYLAND_EGLSTREAM_WL
../src/wayland-eglsurface.c:1521:10: note: each undeclared identifier is reported only once for each function it appears in

Searching for that error online lead me to an upstream issue [3] and commit [4].  If I'm understanding things correctly, I think this commit needs to get backported to the RHEL package in order for it to build in the future.  A build against the current buildroot should be sufficient to reproduce the behavior.

I understand fixing this in 8.3 is most likely, but please consider fixing this in 8.2 as well.  An 8.3 fix will be sufficient to resolve the issue for CentOS Stream soon, but won't help with the CentOS 8.2 rebuild effort.


Version-Release number of selected component (if applicable):
egl-wayland-1.1.4-1.el8
mesa-19.3.0-3.rc4.el8


Additional info:
[0]: https://git.centos.org/rpms/egl-wayland/c/5d3572267914e85be44c85aa6859ccbed68859d4?branch=c8s
[1]: https://git.centos.org/rpms/mesa/c/dfba59ace85f917512ecc403d1c20c268008d5ec?branch=c8s
[2]: https://koji.mbox.centos.org/pkgs/work/tasks/2864/92864/build.log
[3]: https://github.com/NVIDIA/egl-wayland/issues/25
[4]: https://github.com/NVIDIA/egl-wayland/commit/4a343a4b563e84c6258efbddf1d910f9dd6e0300

Comment 1 Tomas Pelka 2020-04-21 07:26:40 UTC
Wondering why are you using mesa-19.3.0-3.rc4.el8 this version was never released. The versions are following:

8.2.0 -> mesa-19.3.4-2.el8
8.1.0 -> mesa-19.1.4-2.el8 respectively mesa-19.1.4-3.el8_1
8.0.0 -> mesa-18.3.1-5.el8_0

Can you please give it a try with released version of mesa?

Thanks

Comment 2 Carl George 🤠 2020-04-21 13:44:51 UTC
That's the release [0] that RCM pushed to the CentOS dist-git [1].  I believe it was from the RHEL 8.2 Beta.

I just attempted to rebuild egl-wayland-1.1.4-1.el8 against the current RHEL 8.2 buildroot with mesa-19.3.4-2.el8 and it still failed.


[0]: https://git.centos.org/rpms/mesa/c/dfba59ace85f917512ecc403d1c20c268008d5ec?branch=c8s
[1]: https://git.centos.org/rpms/mesa/commits/c8s

Comment 4 Mark Mielke 2020-07-27 14:23:25 UTC
It's a hack... but if you downgrade mesa and then build, it seems to work for now.

Comment 5 Mark Mielke 2020-07-27 14:25:38 UTC
For an example use case: Trying to unwind the maze of missing devel packages, to build a custom version of TigerVNC.

Comment 6 Carl George 🤠 2020-07-27 15:18:54 UTC
Yup, that's what I did to get egl-wayland-1.1.4-1.el8 to build for CentOS Stream back in April [0].  I temporarily untagged mesa-19.3.0-3.rc4.el8 so that it would build with the previous mesa-19.1.4-3.el8_1.

[0] https://koji.mbox.centos.org/koji/buildinfo?buildID=7013

Comment 7 Pablo Greco 2020-07-27 15:58:46 UTC
I know that RH does't care about things that don't build anymore, or even things that don't even build in the first place (devel files removed), but when Stream can't be built because things were pushed in the wrong order and people from CentOS need to start chasing fixes upstream to do the most basic builds, it goes against RH's interests because Stream stops being "next minor release of RHEL".

This bug is one of the examples https://git.centos.org/rpms/egl-wayland/c/6cafd5f55eb14938bdfb196e2f59ff72f1c7a5c3?branch=c8 but there are others like vulkan-*

I'm not trying to rant here just for the sake of it, we all want what's best for RHEL and for Stream.

Comment 8 Carl George 🤠 2020-07-27 20:10:57 UTC
Created attachment 1702583 [details]
add EGL_WL_bind_wayland_display definitions to wayland-egl-ext.h

Attaching patch from upstream.

https://github.com/NVIDIA/egl-wayland/commit/4a343a4b563e84c6258efbddf1d910f9dd6e0300

Comment 10 Adam Jackson 2020-10-27 18:31:10 UTC
I couldn't really justify backporting just this one patch instead of rebasing to 1.1.5, so I synced with F34 instead.

To ssh://pkgs.devel.redhat.com/rpms/egl-wayland
   432a358..7b898ed  rhel-8.4.0 -> rhel-8.4.0
Found a gating.yaml file in the repo and it is properly configured
Building egl-wayland-1.1.5-3.el8 for rhel-8.4.0-candidate
Created task: 32479035
Task info: https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=32479035

Comment 17 errata-xmlrpc 2021-05-18 15:39:26 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: userspace graphics, xorg-x11, and mesa security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:1804