Bug 1826533

Summary: 'oc adm upgrade' does not warn when dangerous options are used
Product: OpenShift Container Platform Reporter: W. Trevor King <wking>
Component: ocAssignee: W. Trevor King <wking>
Status: CLOSED ERRATA QA Contact: zhou ying <yinzhou>
Severity: low Docs Contact:
Priority: low    
Version: 4.1.zCC: aos-bugs, jokerman, mfojtik
Target Milestone: ---   
Target Release: 4.5.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-07-13 17:29:58 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description W. Trevor King 2020-04-21 22:05:10 UTC
'oc adm upgrade' has reasonable help text around dangerous options like --force, but there is no guarantee that users read the help text.  We should warn on stderr when something dangerous happens to raise awareness to help drive users towards safer workflows.

Comment 3 zhou ying 2020-05-12 03:24:53 UTC
[root@localhost ~]# oc version -o yaml 
clientVersion:
  buildDate: "2020-05-07T22:03:52Z"
  compiler: gc
  gitCommit: f415627b3a8df305c4dd0ada0b4bc1271846a777
  gitTreeState: clean
  gitVersion: 4.5.0-202005072157-f415627
  goVersion: go1.13.4
  major: ""
  minor: ""
  platform: linux/amd64


[root@localhost ~]# oc adm upgrade --to=4.4.0-0.ci-2020-05-07-213751 --force
warning: --force overrides cluster verification of your supplied release image and waives any update precondition failures.
error: already upgrading.

  Reason: ImageVerificationFailed
  Message: Unable to apply 4.4.0-0.ci-2020-05-07-005844: the image may not be safe to use



If you want to upgrade anyway, use --allow-upgrade-with-warnings.

Comment 4 W. Trevor King 2020-05-17 04:28:28 UTC
Does not need a doc update.  Folks who might see these stderr warnings will see them on stderr.  We don't need to call out the change in release notes too.

Comment 5 errata-xmlrpc 2020-07-13 17:29:58 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2409