Bug 1826625

Summary:	Improve performance of externalNodes
Product:	Red Hat Satellite	Reporter:	Pavel Moravec <pmoravec>
Component:	Puppet	Assignee:	Lukas Zapletal <lzap>
Status:	CLOSED ERRATA	QA Contact:	Vladimír Sedmík <vsedmik>
Severity:	high	Docs Contact:
Priority:	high
Version:	6.6.0	CC:	egolov, ekohlvan, ktordeur, lzap, mmccune, tbrisker
Target Milestone:	6.8.0	Keywords:	Performance, Triaged
Target Release:	Unused
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	foreman-2.1.0-0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1851163 (view as bug list)		Environment:
Last Closed:	2020-10-27 13:02:09 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Pavel Moravec 2020-04-22 07:13:33 UTC

Description of problem:
A puppet client run triggers two HostsController#externalNodes requests. It was observed that processing such a request is sometimes very inefficient, taking >2s on average in a real production.

Lzap++ did an analysis in optimizing the code, as summarized in https://github.com/theforeman/foreman/pull/7599 . Based on the scope of code changes, the performance boost can be 9-14times.


Please backport it to 6.7 and add to 6.8.


Version-Release number of selected component (if applicable):
Sat 6.7


How reproducible:
100% on a scaled system

Steps to Reproduce:
1. See generic reproducer (plus particular one for upstream (only?) in https://github.com/theforeman/foreman/pull/7599


Actual results:


Expected results:


Additional info:

Comment 4 Bryan Kearney 2020-04-23 21:03:25 UTC

Upstream bug assigned to lzap

Comment 5 Bryan Kearney 2020-04-23 21:03:27 UTC

Upstream bug assigned to lzap

Comment 6 Bryan Kearney 2020-05-04 16:52:27 UTC

Moving this bug to POST for triage into Satellite 6 since the upstream issue https://projects.theforeman.org/issues/29582 has been resolved.

Comment 7 Ewoud Kohl van Wijngaarden 2020-06-02 13:31:48 UTC

While the linked issue was merged (and is a good improvement), I've filed https://tickets.puppetlabs.com/browse/SERVER-2818 since Puppet is supposed to only call the ENC script once but calls it twice. Fixing this would greatly reduce the number of calls coming in.

Comment 11 errata-xmlrpc 2020-10-27 13:02:09 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: Satellite 6.8 release), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:4366