Bug 1826908
Summary: | [OCP4.4][NMO] Need to provide a good UI experience when putting nodes into maintenance mode fails | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | OpenShift Container Platform | Reporter: | mlammon | ||||||||
Component: | Console Metal3 Plugin | Assignee: | Jiri Tomasek <jtomasek> | ||||||||
Status: | CLOSED CURRENTRELEASE | QA Contact: | mlammon | ||||||||
Severity: | low | Docs Contact: | |||||||||
Priority: | low | ||||||||||
Version: | 4.4 | CC: | abeekhof, achernet, aos-bugs, gharden, jtomasek, msluiter, rawagner, tjelinek | ||||||||
Target Milestone: | --- | Keywords: | Triaged | ||||||||
Target Release: | 4.7.0 | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Whiteboard: | |||||||||||
Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||||
Doc Text: | Story Points: | --- | |||||||||
Clone Of: | |||||||||||
: | 1826914 (view as bug list) | Environment: | |||||||||
Last Closed: | 2020-10-01 16:46:40 UTC | Type: | Bug | ||||||||
Regression: | --- | Mount Type: | --- | ||||||||
Documentation: | --- | CRM: | |||||||||
Verified Versions: | Category: | --- | |||||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||||
Embargoed: | |||||||||||
Bug Depends On: | 1826914 | ||||||||||
Bug Blocks: | |||||||||||
Attachments: |
|
Description
mlammon
2020-04-22 18:20:57 UTC
Created attachment 1680968 [details]
Screen Image of warning
This should be enforced at the NMO level, not the UI. If there is use case for more then (3) masters, perhaps we need to implement how many can be put into a formula so we don't allow (total - 2) Changing the subject, I don't believe there are any other ways that maintenance mode can "fail" rather than take longer than expected. So it would be worth making sure we have UI in place to handle it gracefully. (In reply to Andrew Beekhof from comment #4) > Changing the subject, I don't believe there are any other ways that > maintenance mode can "fail" rather than take longer than expected. > So it would be worth making sure we have UI in place to handle it gracefully. Right, IIUC this relates to proper maintenance progress tracking (https://bugzilla.redhat.com/show_bug.cgi?id=1812354) - as mentioned there NMO does not report pod counts frequently enough Unfortunately there was no capacity this sprint to do this. Moving to upcoming. Lets talk about what we can do in this area for 4.6 Moving to upcoming sprint as there is no action available until dependent bug is fixed. I think this might have been implemented? It appears now in 4.6 it is preventing user with (3) Master from more then (1) in Maintenance @Andrew what do you expect from UI to do here ? Should we disable Start maintenance action if there's already some master in maintenance ? Created attachment 1716255 [details]
Failed maintenance on second master
Im attaching a screenshot so you can take a look how UI looks like when user tries to start maintenance on second master
I like the new warning, looks good! (In reply to Rastislav Wagner from comment #11) > @Andrew what do you expect from UI to do here ? Should we disable Start > maintenance action if there's already some master in maintenance ? In later builds the NMO will intercept and reject the create operation (webhook). So the ask for the UI is to look for and handle that "somehow". Based on Comment 13, moving to 4.7 Created attachment 1718164 [details]
newer message CNV 2.5 NMO v0.7.0
This no longer is an issue and the latest message seems appropriate with CNV 2.5 with v0.7.0 NMO We can close/verify As per comment 18, closing. |