Bug 1826983
| Summary: | [IPI baremetal]: machine api tries to fallback incorrectly to config map for dhcp_range | |||
|---|---|---|---|---|
| Product: | OpenShift Container Platform | Reporter: | Stephen Benjamin <stbenjam> | |
| Component: | Cloud Compute | Assignee: | sdasu | |
| Cloud Compute sub component: | BareMetal Provider | QA Contact: | Amit Ugol <augol> | |
| Status: | CLOSED ERRATA | Docs Contact: | ||
| Severity: | urgent | |||
| Priority: | urgent | CC: | ccrum, pablo.iranzo, rbartal, stbenjam | |
| Version: | 4.5 | Keywords: | Triaged | |
| Target Milestone: | --- | |||
| Target Release: | 4.5.0 | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | ||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | ||
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1829938 (view as bug list) | Environment: | ||
| Last Closed: | 2020-07-13 17:30:26 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 1829938, 1831748 | |||
I would like to see the provisioning CR generated by the installer. That can be gathered by "oc get provisioning -o yaml". After https://github.com/openshift/installer/pull/3496 lands, the template will look like this: apiVersion: metal3.io/v1alpha1 kind: Provisioning metadata: name: provisioning-configuration spec: provisioningInterface: "enp4s0" provisioningIP: "172.22.0.3" provisioningNetworkCIDR: "172.22.0.0/24" provisioningDHCPExternal: true provisioningDHCPRange: "" provisioningOSDownloadURL: "https://releases-art-rhcos.svc.ci.openshift.org/art/storage/releases/rhcos-4.4/44.81.202003110027-0/x86_64/rhcos-44.81.202003110027-0-openstack.x86_64.qcow2.gz?sha256=237b9e0af475bf318abbe8d83d5508c2c3d4cca96fdcdb16edace2cc062216d1" rendered template* I meant, of course proposed fix : https://github.com/openshift/machine-api-operator/pull/568 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2020:2409 |
Description of problem: provisioningDHCPRange can be an empty string in the Provisioning CR if provisioningDHCPExternal is true, but MAO is still trying to fall back to the config map. It should not do that. IMHO, it is 100% OK to assume the installer creates the Provisioning CR, there's no need for backwards compatibility here, and ideally we'd just remove all of this config map stuff, but if we don't want to do that in 4.5, this case needs to get handled. Version-Release number of selected component (if applicable): 4.5 How reproducible: Always Steps to Reproduce: 1. Set provisioningDHCPExternal: true, and provisioningDHCPRange to "" Actual results: name: metal3-dnsmasq ready: false restartCount: 0 started: false state: waiting: message: couldn't find key dhcp_range in ConfigMap openshift-machine-api/metal3-config reason: CreateContainerConfigError Expected results: No error.