Bug 1827219

Summary: [RFE] Remove or Hide the "disk-performance" check in foreman-maintain upgrade since it returns inconsistent results
Product: Red Hat Satellite Reporter: Ashish Humbe <ahumbe>
Component: Satellite MaintainAssignee: Kavita <kgaikwad>
Status: CLOSED ERRATA QA Contact: Jameer Pathan <jpathan>
Severity: medium Docs Contact:
Priority: high    
Version: 6.6.0CC: apatel, bkearney, kgaikwad, ktordeur, kupadhya, mmccune
Target Milestone: 6.8.0Keywords: FutureFeature, PrioBumpGSS, Triaged
Target Release: Unused   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: rubygem-foreman_maintain-0.6.4 Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-10-27 12:38:21 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Ashish Humbe 2020-04-23 12:49:27 UTC
The "disk-performance" check present in the foreman-maintain is showing inconsistent results while performing satellite version upgrade. 

Here is the output shared by a customer using Fiber channel based SAN storage on Satellite server:

====
Disk speed : 22 MB/sec                                                [WARNING]
Slow disk detected /var/lib/pulp mounted on /dev/mapper/sat--server-sat--server--lv.
             Actual disk speed: 22 MB/sec
             Expected disk speed: 60 MB/sec.
WARNING: Low disk speed might have a negative impact on the system.
====

The same concern is raised by other customers using SSD local disk. 

This warning message creates confusion for customers and they report a support case to confirm whether they should be worried about it or not. In those support cases, we have to tell customers to ignore the warning and use --whitelist="disk-performance" option with foreman-maintain to complete the upgrade.

This check was important when we changed the directory structure of /var/lib/pulp/ in Satellite 6.3 but in recent releases, we are not making any such filesystem level movements. So to avoid the confusion for customer it would be better to hide the check.

Comment 4 Kavita 2020-04-29 14:53:39 UTC
Created redmine issue https://projects.theforeman.org/issues/29654 from this bug

Comment 5 Bryan Kearney 2020-04-30 12:18:15 UTC
Moving this bug to POST for triage into Satellite 6 since the upstream issue https://projects.theforeman.org/issues/29654 has been resolved.

Comment 6 Jameer Pathan 2020-06-10 06:46:22 UTC
Verified

Verified with:
- Satellite 6.8.0 snap 3
- rubygem-foreman_maintain-0.6.4-1.el7sat.noarch

Steps:
- foreman-maintain upgrade check --target-version 6.8.z

Observation:
- pre-upgrade checks didn't include disk-performance check. Now the check won't run during satellite upgrade.
- Check is still available to use and it's listed in "foreman-maintain health list".
- Users can still run the check if they want to, by using "foreman-maintain health check --label disk-performance" command.

Comment 9 errata-xmlrpc 2020-10-27 12:38:21 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Satellite 6.8 Satellite Maintenance Release), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4365

Comment 10 Red Hat Bugzilla 2024-07-24 04:25:15 UTC
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 120 days