Bug 1827504

Summary:	CVE-2020-10663 ruby:2.6/ruby: rubygem-json: Unsafe Object Creation Vulnerability in JSON [fedora-all]
Product:	[Fedora] Fedora	Reporter:	Pedro Sampaio <psampaio>
Component:	ruby	Assignee:	Jun Aruga <jaruga>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	31	CC:	jaruga, mo, mtasaka, pvalena, ruby-packagers-sig, s, strzibny, vanmeeuwen+fedora, vondruch
Target Milestone:	---	Keywords:	Security, SecurityTracking
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-08-19 10:23:19 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1827500

Description Pedro Sampaio 2020-04-24 04:19:15 UTC

This is an automatically created tracking bug!  It was created to ensure
that one or more security vulnerabilities are fixed in affected versions
of fedora-all.

For comments that are specific to the vulnerability please use bugs filed
against the "Security Response" product referenced in the "Blocks" field.

For more information see:
http://fedoraproject.org/wiki/Security/TrackingBugs

When submitting as an update, use the fedpkg template provided in the next
comment(s).  This will include the bug IDs of this tracking bug as well as
the relevant top-level CVE bugs.

Please also mention the CVE IDs being fixed in the RPM changelog and the
fedpkg commit message.

NOTE: this issue affects multiple supported versions of Fedora. While only
one tracking bug has been filed, please correct all affected versions at
the same time.  If you need to fix the versions independent of each other,
you may clone this bug as appropriate.

Comment 1 Pedro Sampaio 2020-04-24 04:19:20 UTC

Use the following template to for the 'fedpkg update' request to submit an
update for this issue as it contains the top-level parent bug(s) as well as
this tracking bug.  This will ensure that all associated bugs get updated
when new packages are pushed to stable.

=====

# bugfix, security, enhancement, newpackage (required)
type=security

# low, medium, high, urgent (required)
severity=medium

# testing, stable
request=testing

# Bug numbers: 1234,9876
bugs=1827500,1827504

# Description of your update
notes=Security fix for [PUT CVEs HERE]

# Enable request automation based on the stable/unstable karma thresholds
autokarma=True
stable_karma=3
unstable_karma=-3

# Automatically close bugs when this marked as stable
close_bugs=True

# Suggest that users restart after update
suggest_reboot=False

======

Additionally, you may opt to use the bodhi web interface to submit updates:

https://bodhi.fedoraproject.org/updates/new

Comment 2 Vít Ondruch 2020-07-27 13:43:15 UTC

@jaruga do you think you would possibly find cycles to do something about this?

Comment 3 Jun Aruga 2020-07-28 07:28:50 UTC

Vit. Yes. I can work on it. But I think it's after we see the following unstable tests in s390x will be fixed with your favourite way like your patch [1][2] to TestBugReporter#test_bug_reporter_add. Because we saw it prevented us from building the module on Fedora s390x environment.

* TestProcess#test_status_quit
* TestRubyOptions#test_segv_test
* TestRubyOptions#test_segv_loaded_features
* TestRubyOptions#test_segv_setproctitle
* TestSignal#test_ignored_interrupt

We also need to replace 180 in assert_in_delta [3] with enough number such as 1000 by possibly sed command for the s390x.

```
  1) Failure:
Fiddle::TestFunction#test_nogvl_poll [/builddir/build/BUILD/ruby-2.7.1/test/fiddle/test_function.rb:95]:
slept amount of time.
Expected |200 - 714| (514) to be <= 180.
```

[1] https://bugs.ruby-lang.org/attachments/8500
[2] https://src.fedoraproject.org/rpms/ruby/c/4979be53acdcfd0d6021c4f209403c2e88fae58e?branch=master
[3] https://github.com/ruby/ruby/blob/7fb12be99fecc5029d540924fc25a1457472451c/test/fiddle/test_function.rb#L114

Comment 4 Vít Ondruch 2020-07-28 08:12:45 UTC

(In reply to Jun Aruga from comment #3)
> [2]
> https://src.fedoraproject.org/rpms/ruby/c/
> 4979be53acdcfd0d6021c4f209403c2e88fae58e?branch=master

Feel free to cherry-pick this.

The other tests needs a lot of investigation unfortunately. So I would give it try if it pass the build.

Comment 5 Jun Aruga 2020-08-19 10:23:19 UTC

Ruby 2.6.6 in Ruby module 2.6 fixing this issue was build on the following build roots from f34 to f31.

f34: https://koji.fedoraproject.org/koji/buildinfo?buildID=1590891
f33: https://koji.fedoraproject.org/koji/buildinfo?buildID=1590892
f32: https://koji.fedoraproject.org/koji/buildinfo?buildID=1590890
f31: https://koji.fedoraproject.org/koji/buildinfo?buildID=1590893