Bug 1827777

Summary: Typo in Upgradable False Condition
Product: OpenShift Container Platform Reporter: Evan Cordell <ecordell>
Component: OLMAssignee: Anik <anbhatta>
OLM sub component: OLM QA Contact: yhui
Status: CLOSED ERRATA Docs Contact:
Severity: low    
Priority: low CC: anbhatta, bluddy, jiazha, krizza, nhale, shurley, wking, yhui
Version: 4.4   
Target Milestone: ---   
Target Release: 4.4.z   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1827775 Environment:
Last Closed: 2020-10-13 08:17:44 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1827775    
Bug Blocks:    

Description Evan Cordell 2020-04-24 18:51:27 UTC 
+++ This bug was initially created as a clone of Bug #1827775 +++

Description of problem:
      message: 'Cluster operator marketplace cannot be upgraded: The cluster has custom
        OperatorSource/CatalogSourceConfig, which are deprecated in future versions.
        Please visit this link for further deatils: https://docs.openshift.com/container-platform/4.4/release_notes/ocp-4-4-release-notes.html#ocp-4-4-marketplace-apis-deprecated'
      reason: DprecatedAPIsInUse


s/DprecatedAPIsInUse/DeprecatedAPIsInUse/g
s/deatils/details/g


Version-Release number of selected component (if applicable):


How reproducible:
100%

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:
Comment 1 Anik 2020-04-27 16:10:47 UTC 
https://github.com/operator-framework/operator-marketplace/pull/305
Comment 3 Evan Cordell 2020-05-07 15:34:05 UTC 
CI has passed, waiting on approval and cherry-pick-approved to merge.
Comment 7 yhui 2020-06-23 08:40:06 UTC 
Version:
[root@preserve-olm-env ansible-operator-webhook-poc]# oc get clusterversion
NAME      VERSION                             AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.4.0-0.nightly-2020-06-22-103843   True        False         102m    Cluster version is 4.4.0-0.nightly-2020-06-22-103843
[root@preserve-olm-env ansible-operator-webhook-poc]# oc exec catalog-operator-f78cc6b49-l6sgq -n openshift-operator-lifecycle-manager -- olm --version
OLM version: 0.14.2
git commit: 759ff4592854c066797cac51bf8ee7f460b9a59a

Steps:
[root@preserve-olm-env ansible-operator-webhook-poc]# oc get clusteroperator marketplace -o yaml
apiVersion: config.openshift.io/v1
kind: ClusterOperator
metadata:
  creationTimestamp: "2020-06-23T06:39:25Z"
  generation: 1
  name: marketplace
  resourceVersion: "20784"
  selfLink: /apis/config.openshift.io/v1/clusteroperators/marketplace
  uid: eb3aafef-5974-4f45-85c6-ac733f983cc0
spec: {}
status:
  conditions:
  - lastTransitionTime: "2020-06-23T06:39:46Z"
    message: 'Successfully progressed to release version: 4.4.0-0.nightly-2020-06-22-103843'
    reason: OperatorAvailable
    status: "False"
    type: Progressing
  - lastTransitionTime: "2020-06-23T06:39:46Z"
    message: 'Available release version: 4.4.0-0.nightly-2020-06-22-103843'
    reason: OperatorAvailable
    status: "True"
    type: Available
  - lastTransitionTime: "2020-06-23T06:52:07Z"
    message: 'The cluster has custom OperatorSource/CatalogSourceConfig, which are
      deprecated in future versions. Please visit this link for further deatils: https://docs.openshift.com/container-platform/4.4/release_notes/ocp-4-4-release-notes.html#ocp-4-4-marketplace-apis-deprecated'
    reason: DeprecatedAPIsInUse
    status: "False"
    type: Upgradeable
  - lastTransitionTime: "2020-06-23T06:39:25Z"
    message: Current CR sync ratio (1) meets the expected success ratio (0.3)
    reason: OperandTransitionsSucceeding
    status: "False"
    type: Degraded
  extension: null
  relatedObjects:
  - group: ""
    name: openshift-marketplace
    resource: namespaces
  - group: operators.coreos.com
    name: ""
    namespace: openshift-marketplace
    resource: OperatorSource
  - group: operators.coreos.com
    name: ""
    namespace: openshift-marketplace
    resource: CatalogSourceConfig
  - group: operators.coreos.com
    name: ""
    namespace: openshift-marketplace
    resource: CatalogSource
  versions:
  - name: operator
    version: 4.4.0-0.nightly-2020-06-22-103843


The typo has not been fixed completely.

message: 'The cluster has custom OperatorSource/CatalogSourceConfig, which are
      deprecated in future versions. Please visit this link for further deatils: https://docs.openshift.com/container-platform/4.4/release_notes/ocp-4-4-release-notes.html#ocp-4-4-marketplace-apis-deprecated'
    reason: DeprecatedAPIsInUse

s/deatils/details/g
Comment 8 W. Trevor King 2020-06-24 05:41:21 UTC 
https://bugzilla.redhat.com/show_bug.cgi?id=1827775#c3 links https://github.com/operator-framework/operator-marketplace/pull/302/files#diff-a5666326aefdf43a8e89fd4871449fa0L58 which landed the "deatils" -> "details" fix in master/4.5 (among other changes).
Comment 14 yhui 2020-08-24 10:03:55 UTC 
Version:
[root@preserve-olm-env memcached-operator]# oc get clusterversion
NAME      VERSION                             AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.4.0-0.nightly-2020-08-23-194129   True        False         154m    Cluster version is 4.4.0-0.nightly-2020-08-23-194129
[root@preserve-olm-env memcached-operator]# oc exec olm-operator-66775bbf8f-d54zp -n openshift-operator-lifecycle-manager -- olm --version
OLM version: 0.14.2
git commit: d1ebc80b9ac1612b003f2f0f36639d7edca45f39


Steps to test:
[root@preserve-olm-env memcached-operator]# oc get clusteroperator marketplace -o yaml
apiVersion: config.openshift.io/v1
kind: ClusterOperator
metadata:
  creationTimestamp: "2020-08-24T07:09:02Z"
  generation: 1
  name: marketplace
  resourceVersion: "52645"
  selfLink: /apis/config.openshift.io/v1/clusteroperators/marketplace
  uid: 89008694-e12a-4e5f-91ae-ebb37027fcd3
spec: {}
status:
  conditions:
  - lastTransitionTime: "2020-08-24T07:09:23Z"
    message: 'Successfully progressed to release version: 4.4.0-0.nightly-2020-08-23-194129'
    reason: OperatorAvailable
    status: "False"
    type: Progressing
  - lastTransitionTime: "2020-08-24T07:09:23Z"
    message: 'Available release version: 4.4.0-0.nightly-2020-08-23-194129'
    reason: OperatorAvailable
    status: "True"
    type: Available
  - lastTransitionTime: "2020-08-24T07:27:04Z"
    message: 'The cluster has custom OperatorSource/CatalogSourceConfig, which are deprecated in future versions. Please visit this link for further deatils: https://docs.openshift.com/container-platform/4.4/release_notes/ocp-4-4-release-notes.html#ocp-4-4-marketplace-apis-deprecated'
    reason: DeprecatedAPIsInUse
    status: "False"
    type: Upgradeable
  - lastTransitionTime: "2020-08-24T07:09:02Z"
    message: Current CR sync ratio (0.96666664) meets the expected success ratio (0.3)
    reason: OperandTransitionsSucceeding
    status: "False"
    type: Degraded
  extension: null
  relatedObjects:
  - group: ""
    name: openshift-marketplace
    resource: namespaces
  - group: operators.coreos.com
    name: ""
    namespace: openshift-marketplace
    resource: OperatorSource
  - group: operators.coreos.com
    name: ""
    namespace: openshift-marketplace
    resource: CatalogSourceConfig
  - group: operators.coreos.com
    name: ""
    namespace: openshift-marketplace
    resource: CatalogSource
  versions:
  - name: operator
    version: 4.4.0-0.nightly-2020-08-23-194129

The typo has not been fixed completely.

message: 'The cluster has custom OperatorSource/CatalogSourceConfig, which are deprecated in future versions. Please visit this link for further deatils: https://docs.openshift.com/container-platform/4.4/release_notes/ocp-4-4-release-notes.html#ocp-4-4-marketplace-apis-deprecated'
    reason: DeprecatedAPIsInUse

s/deatils/details/g

Assigned the bug.
Comment 18 yhui 2020-09-14 08:15:51 UTC 
Version:
[hui@localhost verification-tests]$ oc get clusterversion
NAME      VERSION                             AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.4.0-0.nightly-2020-09-13-231918   True        False         33m     Cluster version is 4.4.0-0.nightly-2020-09-13-231918
[hui@localhost verification-tests]$ oc exec olm-operator-d8dc4bb75-l6fxq -n openshift-operator-lifecycle-manager -- olm --version
OLM version: 0.14.2
git commit: 6307c54ea472e772de9d421201ce5a1ef1f74134


Steps to test:
[hui@localhost verification-tests]$ oc get clusteroperator marketplace -o yaml
apiVersion: config.openshift.io/v1
kind: ClusterOperator
metadata:
  creationTimestamp: "2020-09-14T07:09:41Z"
  generation: 1
  name: marketplace
  resourceVersion: "21921"
  selfLink: /apis/config.openshift.io/v1/clusteroperators/marketplace
  uid: 7fec80aa-8cf9-4273-86ea-3a3b1139adc4
spec: {}
status:
  conditions:
  - lastTransitionTime: "2020-09-14T07:26:06Z"
    message: 'Successfully progressed to release version: 4.4.0-0.nightly-2020-09-13-231918'
    reason: OperatorAvailable
    status: "False"
    type: Progressing
  - lastTransitionTime: "2020-09-14T07:26:06Z"
    message: 'Available release version: 4.4.0-0.nightly-2020-09-13-231918'
    reason: OperatorAvailable
    status: "True"
    type: Available
  - lastTransitionTime: "2020-09-14T07:38:07Z"
    message: 'The cluster has custom OperatorSource/CatalogSourceConfig, which are
      deprecated in future versions. Please visit this link for further deatils: https://docs.openshift.com/container-platform/4.4/release_notes/ocp-4-4-release-notes.html#ocp-4-4-marketplace-apis-deprecated'
    reason: DeprecatedAPIsInUse
    status: "False"
    type: Upgradeable
  - lastTransitionTime: "2020-09-14T07:25:44Z"
    message: Current CR sync ratio (1) meets the expected success ratio (0.3)
    reason: OperandTransitionsSucceeding
    status: "False"
    type: Degraded
  extension: null
  relatedObjects:
  - group: ""
    name: openshift-marketplace
    resource: namespaces
  - group: operators.coreos.com
    name: ""
    namespace: openshift-marketplace
    resource: OperatorSource
  - group: operators.coreos.com
    name: ""
    namespace: openshift-marketplace
    resource: CatalogSourceConfig
  - group: operators.coreos.com
    name: ""
    namespace: openshift-marketplace
    resource: CatalogSource
  versions:
  - name: operator
    version: 4.4.0-0.nightly-2020-09-13-231918

The typo has not been fixed. ->  "Please visit this link for further deatils:"

s/deatils/details/g

Assigned the bug.
Comment 21 yhui 2020-09-17 09:17:39 UTC 
Hi Kevin,

The typo is "deatils", should be changed to "details". The "DeprecatedAPIsInUse" is correct.

"Please visit this link for further deatils:"

s/deatils/details/g
Comment 27 yhui 2020-09-18 16:54:38 UTC 
If this bug is only used to track the typo "DeprecatedAPIsInUse". I will verify it.

For the typo "deatils", could you open another bug or use another way to track?  Anyway, please let us know if it is fixed on 4.4. Thanks!

[hui@localhost verification-tests]$ oc get clusteroperator marketplace -o yaml
apiVersion: config.openshift.io/v1
kind: ClusterOperator
metadata:
  creationTimestamp: "2020-09-14T07:09:41Z"
  generation: 1
  name: marketplace
  resourceVersion: "21921"
  selfLink: /apis/config.openshift.io/v1/clusteroperators/marketplace
  uid: 7fec80aa-8cf9-4273-86ea-3a3b1139adc4
spec: {}
status:
  conditions:
  - lastTransitionTime: "2020-09-14T07:26:06Z"
    message: 'Successfully progressed to release version: 4.4.0-0.nightly-2020-09-13-231918'
    reason: OperatorAvailable
    status: "False"
    type: Progressing
  - lastTransitionTime: "2020-09-14T07:26:06Z"
    message: 'Available release version: 4.4.0-0.nightly-2020-09-13-231918'
    reason: OperatorAvailable
    status: "True"
    type: Available
  - lastTransitionTime: "2020-09-14T07:38:07Z"
    message: 'The cluster has custom OperatorSource/CatalogSourceConfig, which are
      deprecated in future versions. Please visit this link for further deatils: https://docs.openshift.com/container-platform/4.4/release_notes/ocp-4-4-release-notes.html#ocp-4-4-marketplace-apis-deprecated'
    reason: DeprecatedAPIsInUse
    status: "False"
    type: Upgradeable
  - lastTransitionTime: "2020-09-14T07:25:44Z"
    message: Current CR sync ratio (1) meets the expected success ratio (0.3)
    reason: OperandTransitionsSucceeding
    status: "False"
    type: Degraded
  extension: null
  relatedObjects:
  - group: ""
    name: openshift-marketplace
    resource: namespaces
  - group: operators.coreos.com
    name: ""
    namespace: openshift-marketplace
    resource: OperatorSource
  - group: operators.coreos.com
    name: ""
    namespace: openshift-marketplace
    resource: CatalogSourceConfig
  - group: operators.coreos.com
    name: ""
    namespace: openshift-marketplace
    resource: CatalogSource
  versions:
  - name: operator
    version: 4.4.0-0.nightly-2020-09-13-231918


The typo "DeprecatedAPIsInUse" is fixed. But the typo "deatils" is waiting for another fix.
Comment 28 W. Trevor King 2020-09-18 17:13:42 UTC 
"deatils" is not fixed in 4.4:

  $ git --no-pager log --oneline -1 origin/release-4.4
  34fd70b3 (origin/release-4.4) Merge pull request #292 from openshift-cherrypick-robot/cherry-pick-288-to-release-4.4
  $ git --no-pager grep deatils 34fd70b3
  34fd70b3:pkg/status/status.go:	deprecatedAPIMessage = "The cluster has custom OperatorSource/CatalogSourceConfig, which are deprecated in future versions. Please visit this link for further deatils: https://docs.openshift.com/container-platform/4.4/release_notes/ocp-4-4-release-notes.html#ocp-4-4-marketplace-apis-deprecated"

But folks will likely understand even with the typo, and as comment 8 shows, the typo was fixed in 4.5 and later.  4.4 is in maintenance mode [1], and "deatils" is low enough severity that I doubt it's worth a bug chain about fixing in 4.4 and earlier.

[1]: https://access.redhat.com/support/policy/updates/openshift#dates
Comment 31 errata-xmlrpc 2020-10-13 08:17:44 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.4.27 bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4063