Bug 1827818

Summary:	custom button api create getting undefined update for nil error
Product:	Red Hat CloudForms Management Engine	Reporter:	drew uhlmann <duhlmann>
Component:	API	Assignee:	drew uhlmann <duhlmann>
Status:	CLOSED ERRATA	QA Contact:	Nikhil Dhandre <ndhandre>
Severity:	medium	Docs Contact:	Red Hat CloudForms Documentation <cloudforms-docs>
Priority:	high
Version:	5.11.0	CC:	akarol, dmetzger, ndhandre, obarenbo, simaishi
Target Milestone:	GA	Keywords:	ZStream
Target Release:	5.11.9	Flags:	simaishi: cfme-5.11.z+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	5.11.9.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-11-05 22:04:52 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	Bug
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	CFME Core	Target Upstream Version:
Embargoed:

Description drew uhlmann 2020-04-24 21:11:20 UTC

Description of problem:

creating custom buttons over the api fails if the resource action is not present and the error handling isn't showing the message because it expects a custom button to have been created already


Version-Release number of selected component (if applicable):
5.11 and on

How reproducible:
every time

was introduced in https://github.com/ManageIQ/manageiq-api/pull/728


Steps to Reproduce:
1. create a custom button over the api
2.
3.

Actual results:
it fails

Expected results:
it shouldn't fail 

Additional info:

Comment 2 drew uhlmann 2020-04-24 21:12:01 UTC

https://github.com/ManageIQ/manageiq-api/pull/814

Comment 3 drew uhlmann 2020-04-29 16:15:11 UTC

*** Bug 1829279 has been marked as a duplicate of this bug. ***

Comment 5 CFME Bot 2020-05-01 23:51:17 UTC

New commit detected on ManageIQ/manageiq-api/jansa:

https://github.com/ManageIQ/manageiq-api/commit/7ee5c5aefbe7d742d3813ce8a165b91bb317d8ae
commit 7ee5c5aefbe7d742d3813ce8a165b91bb317d8ae
Author:     Brandon Dunne <bdunne>
AuthorDate: Wed Apr 29 19:33:53 2020 +0000
Commit:     Brandon Dunne <bdunne>
CommitDate: Wed Apr 29 19:33:53 2020 +0000

    Merge pull request #814 from d-m-u/custom_buttons_take_two

    fix the custom button create

    (cherry picked from commit 6b3146014c9740b3048a5e12d0c180a042f0840c)

    https://bugzilla.redhat.com/show_bug.cgi?id=1827818

 app/controllers/api/custom_buttons_controller.rb | 6 +-
 1 file changed, 3 insertions(+), 3 deletions(-)

Comment 6 CFME Bot 2020-09-30 17:11:19 UTC

New commit detected on ManageIQ/manageiq-api/ivanchuk:

https://github.com/ManageIQ/manageiq-api/commit/48fdfa0a788cdcd3ba3e8ce7177e46f21d4674dd
commit 48fdfa0a788cdcd3ba3e8ce7177e46f21d4674dd
Author:     Brandon Dunne <bdunne>
AuthorDate: Wed Apr 29 19:33:53 2020 +0000
Commit:     Satoe Imaishi <simaishi>
CommitDate: Wed Sep 30 17:08:23 2020 +0000

    Merge pull request #814 from d-m-u/custom_buttons_take_two

    fix the custom button create

    (cherry picked from commit 6b3146014c9740b3048a5e12d0c180a042f0840c)

    https://bugzilla.redhat.com/show_bug.cgi?id=1827818

 app/controllers/api/custom_buttons_controller.rb | 6 +-
 1 file changed, 3 insertions(+), 3 deletions(-)

Comment 7 Nikhil Dhandre 2020-11-02 06:50:35 UTC

Works fine for me

Comment 12 errata-xmlrpc 2020-11-05 22:04:52 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (CloudForms 5.0.9 bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4967