Bug 1828044

Summary: [ansible-freeipa] Expecting a proper error message for a password required while adding vault with default type in vault module
Product: Red Hat Enterprise Linux 8 Reporter: Varun Mylaraiah <mvarun>
Component: ansible-freeipaAssignee: Rafael Jeffman <rjeffman>
Status: CLOSED ERRATA QA Contact: ipa-qe <ipa-qe>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 8.3CC: rjeffman, twoerner
Target Milestone: rcFlags: pm-rhel: mirror+
Target Release: 8.0   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: ansible-freeipa-0.1.11-1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-11-04 02:46:35 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Varun Mylaraiah 2020-04-26 12:31:16 UTC
Description of problem:
In Ansible-freeipa vault module, Expecting a proper error message for a password required while adding vault with default type(symmetric)

Version-Release number of selected component (if applicable):
ansible-freeipa-0.1.9-1.fc31.noarch

Steps to Reproduce:
[root@ansible ~]# cat symvault4.yaml
---
- name: Test vault
  hosts: ipaserver

  tasks:
  - name: vault module testing
    ipavault:
      ipaadmin_password: <xxxxxxxxxxx>
      name: symvault4
      username: vault_user4

[root@ansible ~]# 
[root@ansible ~]# ansible-playbook -vv -i inventory/server.hosts symvault4.yaml
ansible-playbook 2.9.6
  config file = /etc/ansible/ansible.cfg
  configured module search path = ['/root/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python3.7/site-packages/ansible
  executable location = /usr/bin/ansible-playbook
  python version = 3.7.6 (default, Jan 30 2020, 09:44:41) [GCC 9.2.1 20190827 (Red Hat 9.2.1-1)]
Using /etc/ansible/ansible.cfg as config file

PLAYBOOK: symvault4.yaml ********************************************************************************************************************************************************************************************
1 plays in symvault4.yaml

PLAY [Test vault] ***************************************************************************************************************************************************************************************************

TASK [Gathering Facts] **********************************************************************************************************************************************************************************************
task path: /root/symvault4.yaml:2
[DEPRECATION WARNING]: Distribution fedora 31 on host master.ipadomain.test should use /usr/bin/python3, but is using /usr/bin/python for backward compatibility with prior Ansible releases. A future Ansible 
release will default to using the discovered platform python for this host. See https://docs.ansible.com/ansible/2.9/reference_appendices/interpreter_discovery.html for more information. This feature will be 
removed in version 2.12. Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg.
ok: [master.ipadomain.test]
META: ran handlers

TASK [vault module testing] *****************************************************************************************************************************************************************************************
task path: /root/symvault4.yaml:6
fatal: [master.ipadomain.test]: FAILED! => {"changed": false, "msg": "vault_archive: symvault4: textui"}

PLAY RECAP **********************************************************************************************************************************************************************************************************
master.ipadomain.test      : ok=1    changed=0    unreachable=0    failed=1    skipped=0    rescued=0    ignored=0   




Actual results:

FAILED! => {"changed": false, "msg": "vault_archive: symvault4: textui"}

Expected results:
Required proper error message for password missing with symmetric type vault

Comment 1 Rafael Jeffman 2020-05-07 03:07:43 UTC
Proposed fix on upstream PR: https://github.com/freeipa/ansible-freeipa/pull/263

Comment 3 Rafael Jeffman 2020-06-05 19:30:27 UTC
Upstream PR was merged.

Comment 7 Varun Mylaraiah 2020-08-04 06:11:30 UTC
Verified

ansible-freeipa-0.1.12-5.el8.noarch

Automation test result:
ansible-freeipa-tests/ansible_freeipa_tests/vault_module.py::TestMiscellaneousVaultTests::()::test_default_vault_add_without_password
------------------------------ Captured log call -------------------------------
channel.py                1212 DEBUG    [chan 82] Max packet in: 32768 bytes
channel.py                1212 DEBUG    [chan 82] Max packet out: 32768 bytes
transport.py              1819 DEBUG    Secsh channel 82 opened.
transport.py               318 INFO     RUN ['ipactl', 'status']
transport.py               519 DEBUG    RUN ['ipactl', 'status']
channel.py                1212 DEBUG    [chan 82] Sesch channel 82 request ok
transport.py               563 DEBUG    -bash: line 1: cd: /root/multihost_tests: No such file or directory
transport.py               563 DEBUG    -bash: line 2: /root/multihost_tests/env.sh: No such file or directory
transport.py               563 DEBUG    Directory Service: RUNNING
transport.py               563 DEBUG    krb5kdc Service: RUNNING
transport.py               563 DEBUG    kadmin Service: RUNNING
transport.py               563 DEBUG    named Service: RUNNING
transport.py               563 DEBUG    httpd Service: RUNNING
transport.py               563 DEBUG    ipa-custodia Service: RUNNING
transport.py               563 DEBUG    pki-tomcatd Service: RUNNING
transport.py               563 DEBUG    ipa-otpd Service: RUNNING
transport.py               563 DEBUG    ipa-dnskeysyncd Service: RUNNING
transport.py               563 DEBUG    ipa: INFO: The ipactl command was successful
channel.py                1212 DEBUG    [chan 82] EOF received (82)
channel.py                1212 DEBUG    [chan 82] EOF sent (82)
transport.py               217 DEBUG    Exit code: 0
channel.py                1212 DEBUG    [chan 83] Max packet in: 32768 bytes
channel.py                1212 DEBUG    [chan 83] Max packet out: 32768 bytes
transport.py              1819 DEBUG    Secsh channel 83 opened.
transport.py               318 INFO     RUN ['kinit', 'admin']
transport.py               519 DEBUG    RUN ['kinit', 'admin']
channel.py                1212 DEBUG    [chan 83] Sesch channel 83 request ok
transport.py               563 DEBUG    -bash: line 1: cd: /root/multihost_tests: No such file or directory
transport.py               563 DEBUG    -bash: line 2: /root/multihost_tests/env.sh: No such file or directory
transport.py               563 DEBUG    Password for admin: 
channel.py                1212 DEBUG    [chan 83] EOF received (83)
channel.py                1212 DEBUG    [chan 83] EOF sent (83)
transport.py               217 DEBUG    Exit code: 0
channel.py                1212 DEBUG    [chan 84] Max packet in: 32768 bytes
channel.py                1212 DEBUG    [chan 84] Max packet out: 32768 bytes
transport.py              1819 DEBUG    Secsh channel 84 opened.
transport.py               318 INFO     RUN ['ipa', 'vault-find']
transport.py               519 DEBUG    RUN ['ipa', 'vault-find']
channel.py                1212 DEBUG    [chan 84] Sesch channel 84 request ok
transport.py               563 DEBUG    -bash: line 1: cd: /root/multihost_tests: No such file or directory
transport.py               563 DEBUG    -bash: line 2: /root/multihost_tests/env.sh: No such file or directory
transport.py               563 DEBUG    ----------------
transport.py               563 DEBUG    2 vaults matched
transport.py               563 DEBUG    ----------------
transport.py               563 DEBUG      Vault name: 17stdvault
transport.py               563 DEBUG      Type: standard
transport.py               563 DEBUG      Vault user: admin
transport.py               563 DEBUG    
transport.py               563 DEBUG      Vault name: 21stdvault
transport.py               563 DEBUG      Type: standard
transport.py               563 DEBUG      Vault user: admin
transport.py               563 DEBUG    ----------------------------
transport.py               563 DEBUG    Number of entries returned 2
transport.py               563 DEBUG    ----------------------------
channel.py                1212 DEBUG    [chan 84] EOF received (84)
channel.py                1212 DEBUG    [chan 84] EOF sent (84)
transport.py               217 DEBUG    Exit code: 0
channel.py                1212 DEBUG    [chan 85] Max packet in: 32768 bytes
channel.py                1212 DEBUG    [chan 85] Max packet out: 32768 bytes
transport.py              1819 DEBUG    Secsh channel 85 opened.
transport.py               318 INFO     RUN ['kdestroy', '-A']
transport.py               519 DEBUG    RUN ['kdestroy', '-A']
channel.py                1212 DEBUG    [chan 85] Sesch channel 85 request ok
transport.py               563 DEBUG    -bash: line 1: cd: /root/multihost_tests: No such file or directory
transport.py               563 DEBUG    -bash: line 2: /root/multihost_tests/env.sh: No such file or directory
channel.py                1212 DEBUG    [chan 85] EOF received (85)
channel.py                1212 DEBUG    [chan 85] EOF sent (85)
transport.py               217 DEBUG    Exit code: 0
transport.py               293 INFO     WRITE inventory/vault.hosts
sftp.py                    158 DEBUG    [chan 0] open(b'inventory/vault.hosts', 'wb')
sftp.py                    158 DEBUG    [chan 0] open(b'inventory/vault.hosts', 'wb') -> 00000000
sftp.py                    158 DEBUG    [chan 0] close(00000000)
transport.py               329 INFO     PUT vault_module.yml
sftp.py                    158 DEBUG    [chan 0] open(b'vault_module.yml', 'wb')
sftp.py                    158 DEBUG    [chan 0] open(b'vault_module.yml', 'wb') -> 00000000
sftp.py                    158 DEBUG    [chan 0] close(00000000)
sftp.py                    158 DEBUG    [chan 0] stat(b'vault_module.yml')
channel.py                1212 DEBUG    [chan 18] Max packet in: 32768 bytes
channel.py                1212 DEBUG    [chan 18] Max packet out: 32768 bytes
transport.py              1819 DEBUG    Secsh channel 18 opened.
transport.py               318 INFO     RUN ['ansible-playbook', '--ssh-extra-args="-o StrictHostKeyChecking=no"', '-vv', '-i', 'inventory/vault.hosts', 'vault_module.yml']
transport.py               519 DEBUG    RUN ['ansible-playbook', '--ssh-extra-args="-o StrictHostKeyChecking=no"', '-vv', '-i', 'inventory/vault.hosts', 'vault_module.yml']
channel.py                1212 DEBUG    [chan 18] Sesch channel 18 request ok
transport.py               563 DEBUG    -bash: line 1: cd: /root/multihost_tests: No such file or directory
transport.py               563 DEBUG    -bash: line 2: /root/multihost_tests/env.sh: No such file or directory
transport.py               563 DEBUG    ansible-playbook 2.9.11
transport.py               563 DEBUG      config file = /root/ansible.cfg
transport.py               563 DEBUG      configured module search path = ['/root/ansible-freeipa/plugins/modules', '/usr/share/ansible/plugins/modules']
transport.py               563 DEBUG      ansible python module location = /usr/lib/python3.6/site-packages/ansible
transport.py               563 DEBUG      executable location = /usr/bin/ansible-playbook
transport.py               563 DEBUG      python version = 3.6.8 (default, Jun 26 2020, 12:10:09) [GCC 8.3.1 20191121 (Red Hat 8.3.1-5)]
transport.py               563 DEBUG    Using /root/ansible.cfg as config file
transport.py               563 DEBUG    
transport.py               563 DEBUG    PLAYBOOK: vault_module.yml *****************************************************
transport.py               563 DEBUG    1 plays in vault_module.yml
transport.py               563 DEBUG    
transport.py               563 DEBUG    PLAY [Playbook to ensure the error message is correctly displayed while adding default vault without password.] ***
transport.py               563 DEBUG    
transport.py               563 DEBUG    TASK [Gathering Facts] *********************************************************
transport.py               563 DEBUG    task path: /root/vault_module.yml:2
transport.py               563 DEBUG    ok: [master.ipadomain.test]
transport.py               563 DEBUG    META: ran handlers
transport.py               563 DEBUG    
transport.py               563 DEBUG    TASK [ipavault] ****************************************************************
transport.py               563 DEBUG    task path: /root/vault_module.yml:6
transport.py               563 DEBUG    fatal: [master.ipadomain.test]: FAILED! => {"changed": false, "msg": "Symmetric vault requires password or password_file to store data or change `salt`."}
transport.py               563 DEBUG    
transport.py               563 DEBUG    PLAY RECAP *********************************************************************
transport.py               563 DEBUG    master.ipadomain.test      : ok=1    changed=0    unreachable=0    failed=1    skipped=0    rescued=0    ignored=0   
transport.py               563 DEBUG    
channel.py                1212 DEBUG    [chan 18] EOF received (18)
channel.py                1212 DEBUG    [chan 18] EOF sent (18)
transport.py               217 DEBUG    Exit code: 2
channel.py                1212 DEBUG    [chan 86] Max packet in: 32768 bytes
channel.py                1212 DEBUG    [chan 86] Max packet out: 32768 bytes
transport.py              1819 DEBUG    Secsh channel 86 opened.
transport.py               318 INFO     RUN ['kinit', 'admin']
transport.py               519 DEBUG    RUN ['kinit', 'admin']
channel.py                1212 DEBUG    [chan 86] Sesch channel 86 request ok
transport.py               563 DEBUG    -bash: line 1: cd: /root/multihost_tests: No such file or directory
transport.py               563 DEBUG    -bash: line 2: /root/multihost_tests/env.sh: No such file or directory
transport.py               563 DEBUG    Password for admin: 
channel.py                1212 DEBUG    [chan 86] EOF received (86)
channel.py                1212 DEBUG    [chan 86] EOF sent (86)
transport.py               217 DEBUG    Exit code: 0
channel.py                1212 DEBUG    [chan 87] Max packet in: 32768 bytes
channel.py                1212 DEBUG    [chan 87] Max packet out: 32768 bytes
transport.py              1819 DEBUG    Secsh channel 87 opened.
transport.py               318 INFO     RUN ['ipa', 'vault-find']
transport.py               519 DEBUG    RUN ['ipa', 'vault-find']
channel.py                1212 DEBUG    [chan 87] Sesch channel 87 request ok
transport.py               563 DEBUG    -bash: line 1: cd: /root/multihost_tests: No such file or directory
transport.py               563 DEBUG    -bash: line 2: /root/multihost_tests/env.sh: No such file or directory
transport.py               563 DEBUG    ----------------
transport.py               563 DEBUG    2 vaults matched
transport.py               563 DEBUG    ----------------
transport.py               563 DEBUG      Vault name: 17stdvault
transport.py               563 DEBUG      Type: standard
transport.py               563 DEBUG      Vault user: admin
transport.py               563 DEBUG    
transport.py               563 DEBUG      Vault name: 21stdvault
transport.py               563 DEBUG      Type: standard
transport.py               563 DEBUG      Vault user: admin
transport.py               563 DEBUG    ----------------------------
transport.py               563 DEBUG    Number of entries returned 2
transport.py               563 DEBUG    ----------------------------
channel.py                1212 DEBUG    [chan 87] EOF received (87)
channel.py                1212 DEBUG    [chan 87] EOF sent (87)
transport.py               217 DEBUG    Exit code: 0
channel.py                1212 DEBUG    [chan 88] Max packet in: 32768 bytes
channel.py                1212 DEBUG    [chan 88] Max packet out: 32768 bytes
transport.py              1819 DEBUG    Secsh channel 88 opened.
transport.py               318 INFO     RUN ['kdestroy', '-A']
transport.py               519 DEBUG    RUN ['kdestroy', '-A']
channel.py                1212 DEBUG    [chan 88] Sesch channel 88 request ok
transport.py               563 DEBUG    -bash: line 1: cd: /root/multihost_tests: No such file or directory
transport.py               563 DEBUG    -bash: line 2: /root/multihost_tests/env.sh: No such file or directory
channel.py                1212 DEBUG    [chan 88] EOF received (88)
channel.py                1212 DEBUG    [chan 88] EOF sent (88)
transport.py               217 DEBUG    Exit code: 0

Comment 10 errata-xmlrpc 2020-11-04 02:46:35 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (ansible-freeipa bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2020:4663