Bug 1828067

Summary:	mountOptions is ignored for "import storage domain" from GUI [RHV clone - 4.3.10]
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	RHV bug bot <rhv-bugzilla-bot>
Component:	ovirt-engine	Assignee:	Ahmad Khiet <akhiet>
Status:	CLOSED ERRATA	QA Contact:	Ilan Zuckerman <izuckerm>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	4.3.8-1	CC:	akhiet, mkalinin, mperina, pelauter, rdlugyhe, tnisan
Target Milestone:	ovirt-4.3.10	Keywords:	ZStream
Target Release:	4.3.10	Flags:	lsvaty: testing_plan_complete-
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	ovirt-engine-4.3.10.1	Doc Type:	Bug Fix
Doc Text:	Previously, using the Administration Portal to import a storage domain omitted custom mount options for NFS storage servers. The current release fixes this issue by including the custom mount options.	Story Points:	---
Clone Of:	1810893	Environment:
Last Closed:	2020-06-04 15:04:01 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Storage	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1810893
Bug Blocks:

Description RHV bug bot 2020-04-26 15:48:51 UTC

+++ This bug is a downstream clone. The original bug is: +++
+++   bug 1810893 +++
======================================================================

Description of problem:

while importing the storage domain from GUI with the custom mount options for an NFS storage server, those options are ignored and ConnectStorageServerVDSCommand is initiated with the mountOptions='null'.

However, the mountOptions are correctly passed when adding a new storage domain. The issue is only with the "import storage domain".

Also importing the storage domain using API also works well. The issue is only with the GUI.

Version-Release number of selected component (if applicable):

rhvm-4.3.8.2-0.4.el7.noarch

How reproducible:

100%

Steps to Reproduce:

1. Use "import" option for importing a storage domain and add "Additional mount options" under "Custom Connection Parameters".

2. Check "ConnectStorageServerVDSCommand" in the engine log and watch for mountOptions value. It will be null and mount command spawned in the host will be also without any custom parameters which the user has provided. 

Actual results:

mountOptions is ignored for "import storage domain" from GUI

Expected results:

mountOptions should work while importing storage domain.

Additional info:

(Originally by Nijin Kottungal)

Comment 7 RHV bug bot 2020-04-26 15:49:04 UTC

I have verified the when passing additional mount options from webAdmin UI, they are being passed to the vdsm as additional parameters.
There is still a problem of how vdsm treats those params (for example 'ro'). For this, additional BZ was opened:
https://bugzilla.redhat.com/show_bug.cgi?id=1823207

(Originally by Ilan Zuckerman)

Comment 12 Martin Perina 2020-05-04 12:08:53 UTC

Moving back to MODIFIED as engine fix is not included in latest 4.3.10 compose

Comment 14 Ilan Zuckerman 2020-05-12 13:16:12 UTC

I have verified the when passing additional mount options from webAdmin UI, they are being passed to the vdsm as additional parameters. As so (ilan_test):

2020-05-12 16:12:32,045+03 INFO  [org.ovirt.engine.core.vdsbroker.vdsbroker.DisconnectStorageServerVDSCommand] (default task-20) [d964ae39-87e2-481d-a999-a548abcef753] START, DisconnectStorageServerVDSCommand(HostName = host_mixed_1, StorageServerConnectionManagementVDSParameters:{hostId='5cfa0375-407c-42b5-81e7-c1f7d9377caa', storagePoolId='00000000-0000-0000-0000-000000000000', storageType='NFS', connectionList='[StorageServerConnections:{id='null', connection='yellow-vdsb.qa.lab.tlv.redhat.com:/Storage_NFS/storage_local_ge5_nfs_0', iqn='null', vfsType='null', mountOptions='ilan_test', nfsVersion='AUTO', nfsRetrans='null', nfsTimeo='null', iface='null', netIfaceName='null'}]', sendNetworkEventOnFailure='true'}), log id: 61bd20eb

Also tested additional mount options such as 'rw'

Tested on:
ovirt-engine-4.3.10.1-0.1.master.el7.noarch
vdsm-4.30.46-1.el7ev.x86_64

Comment 17 errata-xmlrpc 2020-06-04 15:04:01 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2396