Bug 1828638

Summary:	[vsphere-ipi] The disksize of master vm is hard coded to 120G, and could not customize through install_config
Product:	OpenShift Container Platform	Reporter:	jima
Component:	Installer	Assignee:	Patrick Dillon <padillon>
Installer sub component:	openshift-installer	QA Contact:	jima
Status:	CLOSED ERRATA	Docs Contact:
Severity:	medium
Priority:	medium	CC:	bleanhar, padillon
Version:	4.5
Target Milestone:	---
Target Release:	4.5.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:	Cause: disk size for master nodes was hard coded Consequence: if a user specified master disk size in the install config it was ignored Fix: read specified value when creating master nodes Result: masters are created with specified disk size	Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-07-13 17:32:07 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description jima 2020-04-28 01:42:45 UTC

Description of problem:
Install vsphere/ipi on ocp4.5 nightly build, after generating install-config through command "openshift-install create install-config, and update install-config to customize cpu,memory and disksize of master node and worker node, then continue installation, the disksize of master is always 120G. After checking code, it is hard coded.
https://github.com/openshift/installer/blob/master/data/data/vsphere/master/main.tf#L23


How reproducible:
100%

Steps to Reproduce:
1. run command "openshift-install create install-config" to generate install-config file
2. update install-config.yaml file to customize cpu,memory and disksize of master node and worker node
--------
apiVersion: v1
baseDomain: qe.devcluster.openshift.com
compute:
- hyperthreading: Enabled
  name: worker
  replicas: 2
  platform:
    vsphere:
      cpus: 4
      coresPerSocket: 2
      memoryMB: 4096
      osDisk:
        diskSizeGB: 50
controlPlane:
  hyperthreading: Enabled
  name: master
  replicas: 3
  platform:
    vsphere:
      cpus: 4
      coresPerSocket: 2
      memoryMB: 8192
      osDisk:
        diskSizeGB: 50
...

3. run command "openshift-install create cluster" to install cluster
4. After vms are created on vsphere server, checked that the disksize on master node is assigned to 120G

Actual results:
The disk size on master node is assigned to 120G

Expected results:
The disk size on master node should be one defined in install-config

Additional info:

Comment 3 jima 2020-05-13 06:35:10 UTC

Verified on 4.5.0-0.nightly-2020-05-13-014437, control_plane vm's disk has been set to expected one in customized install-config.

Comment 4 errata-xmlrpc 2020-07-13 17:32:07 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2409